You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/11/08 11:42:37 UTC

[GitHub] spark pull request #22978: [SPARK-25676][SQL][FOLLOWUP] Use 'foreach(_ => ()...

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22978#discussion_r231856562
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/WideTableBenchmark.scala ---
    @@ -43,7 +42,7 @@ object WideTableBenchmark extends SqlBasedBenchmark {
           Seq("10", "100", "1024", "2048", "4096", "8192", "65536").foreach { n =>
             benchmark.addCase(s"split threshold $n", numIters = 5) { iter =>
               withSQLConf(SQLConf.CODEGEN_METHOD_SPLIT_THRESHOLD.key -> n) {
    -            df.selectExpr(columns: _*).foreach((x => x): Row => Unit)
    +            df.selectExpr(columns: _*).foreach(_ => ())
    --- End diff --
    
    @cloud-fan . This is updated.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org