You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/06/22 17:52:47 UTC

[GitHub] [accumulo] milleruntime opened a new issue #2173: VerifySerialRecoveryIT failure

milleruntime opened a new issue #2173:
URL: https://github.com/apache/accumulo/issues/2173


   This is due to recent changes to sorted log recovery in #2117. There is a bug in the new recovery code with the row byte encoding improperly encoding tabletIds greater than 127.
   
   <pre>
   java.lang.RuntimeException: Error recovering tablet 1;a24391d90602477b;a071870ae421babc from log files
           at org.apache.accumulo.tserver.tablet.Tablet.<init>(Tablet.java:407) ~[accumulo-tserver-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
           at org.apache.accumulo.tserver.AssignmentHandler.run(AssignmentHandler.java:160) [accumulo-tserver-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
           at org.apache.accumulo.tserver.ActiveAssignmentRunnable.run(ActiveAssignmentRunnable.java:63) [accumulo-tserver-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
           at org.apache.htrace.wrappers.TraceRunnable.run(TraceRunnable.java:57) [htrace-core-3.2.0-incubating.jar:3.2.0-incubating]
           at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
           at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
           at java.lang.Thread.run(Thread.java:829) [?:?]
   Caused by: java.io.IOException: java.lang.IllegalStateException: tabletId -128 for 1;a24391d90602477b;a071870ae421babc is negative
           at org.apache.accumulo.tserver.log.TabletServerLogger.recover(TabletServerLogger.java:540) ~[accumulo-tserver-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
           at org.apache.accumulo.tserver.TabletServer.recover(TabletServer.java:1153) ~[accumulo-tserver-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
           at org.apache.accumulo.tserver.tablet.Tablet.<init>(Tablet.java:366) ~[accumulo-tserver-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
           ... 6 more
   Caused by: java.lang.IllegalStateException: tabletId -128 for 1;a24391d90602477b;a071870ae421babc is negative
           at com.google.common.base.Preconditions.checkState(Preconditions.java:707) ~[guava-30.1.1-jre.jar:?]
           at org.apache.accumulo.tserver.log.SortedLogRecovery.findMaxTabletId(SortedLogRecovery.java:120) ~[accumulo-tserver-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
           at org.apache.accumulo.tserver.log.SortedLogRecovery.findLogsThatDefineTablet(SortedLogRecovery.java:147) ~[accumulo-tserver-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
           at org.apache.accumulo.tserver.log.SortedLogRecovery.recover(SortedLogRecovery.java:291) ~[accumulo-tserver-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
           at org.apache.accumulo.tserver.log.TabletServerLogger.recover(TabletServerLogger.java:538) ~[accumulo-tserver-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
           at org.apache.accumulo.tserver.TabletServer.recover(TabletServer.java:1153) ~[accumulo-tserver-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
           at org.apache.accumulo.tserver.tablet.Tablet.<init>(Tablet.java:366) ~[accumulo-tserver-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
           ... 6 more
   </pre>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] ctubbsii commented on issue #2173: VerifySerialRecoveryIT failure

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #2173:
URL: https://github.com/apache/accumulo/issues/2173#issuecomment-866381761


   I made some comments at https://github.com/apache/accumulo/pull/2117#pullrequestreview-690052589 and https://github.com/apache/accumulo/pull/2117#pullrequestreview-690053323 that might be related to this problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] ctubbsii edited a comment on issue #2173: VerifySerialRecoveryIT failure

Posted by GitBox <gi...@apache.org>.
ctubbsii edited a comment on issue #2173:
URL: https://github.com/apache/accumulo/issues/2173#issuecomment-866381761


   I made some comments at https://github.com/apache/accumulo/pull/2117#pullrequestreview-690052589 and https://github.com/apache/accumulo/pull/2117#pullrequestreview-690053323 that might be related to this problem. In addition, there is some funniness casting to a `(byte)` if the value is `255`.
   
   Consider this: `byte b = (byte) 255; int x = 1 + b;`
   This will result in `0`, and not the expected `256`.
   
   Also, I see some attempts to truncate any sign-extension bits, but that's being done before it is cast to a `(byte)`, when it should be done prior to the `|` (currently `+`), because that operator will be operating on sign-extended int versions of the byte, and not the raw byte, so we'd want to remove the effects of sign extension before putting it in the bitwise operation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] milleruntime closed issue #2173: VerifySerialRecoveryIT failure

Posted by GitBox <gi...@apache.org>.
milleruntime closed issue #2173:
URL: https://github.com/apache/accumulo/issues/2173


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] ctubbsii edited a comment on issue #2173: VerifySerialRecoveryIT failure

Posted by GitBox <gi...@apache.org>.
ctubbsii edited a comment on issue #2173:
URL: https://github.com/apache/accumulo/issues/2173#issuecomment-866381761


   I made some comments at https://github.com/apache/accumulo/pull/2117#pullrequestreview-690052589 and https://github.com/apache/accumulo/pull/2117#pullrequestreview-690053323 that might be related to this problem. In addition, there is some funniness casting to a `(byte)` if the value is `255`.
   
   Consider this: `byte b = (byte) 255; int x = 1 + b;`
   This will result in `0`, and not the expected `256`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org