You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2022/12/05 05:57:51 UTC

Change in asterixdb[master]: [ASTERIXDB-3091][MTD] Make DROP TYPE derive correct names

From Ali Alsuliman <al...@gmail.com>:

Attention is currently required from: Ian Maxon, Wail Alkowaileet, Glenn Galvizo.
Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17296 )

Change subject: [ASTERIXDB-3091][MTD] Make DROP TYPE derive correct names
......................................................................


Patch Set 2:

(1 comment)

File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/ddl/drop-anonymous-nested-types/drop-anonymous-nested-types.002.query.sqlpp:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17296/comment/7b066ac4_7c3277e2 
PS2, Line 19: SELECT d.DatatypeName
            : FROM Metadata.Datatype d
            : WHERE starts_with(d.DatatypeName,"UserType");
it would be better if you create the type in its own dataverse. then we can check how the data types look in that dataverse before the drop and after the drop.



-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17296
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I67f3ea5bbd9dd4f5f4b836e765f42ccc1d7b13ca
Gerrit-Change-Number: 17296
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Glenn Galvizo <gg...@uci.edu>
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Wail Alkowaileet <wa...@gmail.com>
Gerrit-Attention: Ian Maxon <im...@uci.edu>
Gerrit-Attention: Wail Alkowaileet <wa...@gmail.com>
Gerrit-Attention: Glenn Galvizo <gg...@uci.edu>
Gerrit-Comment-Date: Mon, 05 Dec 2022 05:57:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment