[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1438: Respect kyuubi.authentication

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #1438:
URL: https://github.com/apache/incubator-kyuubi/pull/1438#discussion_r755821192



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/KinitAuxiliaryService.scala
##########
@@ -36,6 +37,12 @@ class KinitAuxiliaryService() extends AbstractService("KinitAuxiliaryService") {
   private var kinitTask: Runnable = _
 
   override def initialize(conf: KyuubiConf): Unit = {
+    val authTypes = conf.get(KyuubiConf.AUTHENTICATION_METHOD).map(AuthTypes.withName)
+    if (UserGroupInformation.isSecurityEnabled != authTypes.contains(AuthTypes.KERBEROS)) {

Review comment:
       How about
   if (authTypes.contains(AuthTypes.KERBEROS)) {
       require(UserGroupInformation.isSecurityEnabled, "msg")
   }




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org