You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/23 01:39:09 UTC

[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on a change in pull request #4743: [Feature-3805][mater-worker-ui] The implement of passing variables between tasks

CalvinKirs commented on a change in pull request #4743:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4743#discussion_r580713262



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/queue/TaskResponseEvent.java
##########
@@ -128,6 +133,7 @@ public static TaskResponseEvent newResult(ExecutionStatus state,
         event.setEvent(Event.RESULT);
         event.setVarPool(varPool);
         event.setChannel(channel);
+        event.setResult(result);

Review comment:
       When sending an ack message, do you really need this part of the code?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org