You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "PhilDakin (via GitHub)" <gi...@apache.org> on 2023/10/17 18:12:11 UTC
[PR] [SPARK-38723][CORE][STREAMING][TESTS] Add test for streaming query resume race condition. [spark]
PhilDakin opened a new pull request, #43405:
URL: https://github.com/apache/spark/pull/43405
@MaxGekk
### What changes were proposed in this pull request?
Add a test for the CONCURRENT_QUERY error raised when multiple sessions try to simultaneously resume the same streaming query from checkpoint.
### Why are the changes needed?
Improve testing coverage per https://issues.apache.org/jira/browse/SPARK-38723.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Change is itself a test - ran locally and confirmed the suite passes.
```
[info] All tests passed.
[success] Total time: 129 s (02:09), completed Oct 17, 2023, 2:11:34 PM
```
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-38723][SS][TESTS] Add test for streaming query resume race condition [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR closed pull request #43405: [SPARK-38723][SS][TESTS] Add test for streaming query resume race condition
URL: https://github.com/apache/spark/pull/43405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-38723][SS][TESTS] Add test for streaming query resume race condition [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #43405:
URL: https://github.com/apache/spark/pull/43405#issuecomment-1780435097
I see the test failure is not related. Thanks! Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-38723][CORE][STREAMING][TESTS] Add test for streaming query resume race condition. [spark]
Posted by "PhilDakin (via GitHub)" <gi...@apache.org>.
PhilDakin commented on PR #43405:
URL: https://github.com/apache/spark/pull/43405#issuecomment-1775880574
Build failure is in `pyspark` tests, looks unrelated.
@MaxGekk will you review this, or is there someone else to tag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-38723][SQL][STREAMING][TESTS] Add test for streaming query resume race condition. [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #43405:
URL: https://github.com/apache/spark/pull/43405#issuecomment-1776619090
@HeartSaVioR Could you take a look at the PR, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-38723][SS][TESTS] Add test for streaming query resume race condition [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #43405:
URL: https://github.com/apache/spark/pull/43405#issuecomment-1780438242
@PhilDakin Could you please let me know about your ASF JIRA account? It is needed to recognize your effort in ASF JIRA. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org