You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/14 20:53:35 UTC

[GitHub] [airflow] eladkal opened a new issue #20300: Add Github provider

eladkal opened a new issue #20300:
URL: https://github.com/apache/airflow/issues/20300


   ### Body
   
   Add Github provider based on offical Python SDK https://github.com/PyGithub/PyGithub
   The SDK has many objects which can be viewed at https://pygithub.readthedocs.io/en/latest/github_objects.html
   
   It would be nice if we can create a hook that can leverage the package and allow the user to interact with it.
   
   For example: being able to to find when file was last commited.
   
   PR example for creating new provider can be seen on https://github.com/apache/airflow/pull/17068
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] pateash commented on issue #20300: Add Github provider

Posted by GitBox <gi...@apache.org>.
pateash commented on issue #20300:
URL: https://github.com/apache/airflow/issues/20300#issuecomment-996049207


   I would like to take this up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #20300: Add Github provider

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #20300:
URL: https://github.com/apache/airflow/issues/20300#issuecomment-996197179


   Alll providers - by definition - are optional dependencies of Airflow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] uranusjr commented on issue #20300: Add Github provider

Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #20300:
URL: https://github.com/apache/airflow/issues/20300#issuecomment-994430270


   Not sure is async support is useful, but [gidgethub](https://github.com/brettcannon/gidgethub) is another solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk closed issue #20300: Add Github provider

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #20300:
URL: https://github.com/apache/airflow/issues/20300


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on issue #20300: Add Github provider

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #20300:
URL: https://github.com/apache/airflow/issues/20300#issuecomment-996056792


   > @eladkal as far as I know **LGPL-3.0 License** is not compatible with **Apache2** license ( we can use ApacheV2 into LGPL3 but not the otherway around), So we can't use **PyGithub** https://www.apache.org/licenses/GPL-compatibility.html Also I would like to take this up.
   
   This is about Airflow provider. https://github.com/apache/airflow/issues/9898 talks about it at length.
   There shouldn't be a problem with providers packages.
   @kaxil @potiuk can you confirm?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] pateash edited a comment on issue #20300: Add Github provider

Posted by GitBox <gi...@apache.org>.
pateash edited a comment on issue #20300:
URL: https://github.com/apache/airflow/issues/20300#issuecomment-996047771


   @eladkal as far as I know **LGPL-3.0 License** is not compatible with **Apache2** license ( we can use ApacheV2 into LGPL3 but not the otherway around), So we can't use **PyGithub** https://www.apache.org/licenses/GPL-compatibility.html
   Also I would like to take this up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] pateash commented on issue #20300: Add Github provider

Posted by GitBox <gi...@apache.org>.
pateash commented on issue #20300:
URL: https://github.com/apache/airflow/issues/20300#issuecomment-996047771


   @eladkal as far as I know **LGPL-3.0 License** is not compatible with **Apache2** license ( we can use ApacheV2 into LGPL3 but not the otherway around)
   So we can't use **PyGithub**.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] pateash removed a comment on issue #20300: Add Github provider

Posted by GitBox <gi...@apache.org>.
pateash removed a comment on issue #20300:
URL: https://github.com/apache/airflow/issues/20300#issuecomment-996049207


   I would like to take this up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on issue #20300: Add Github provider

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #20300:
URL: https://github.com/apache/airflow/issues/20300#issuecomment-996196472


   It's OK. LGPL Is ok as an optional dependency.
   
   https://www.apache.org/legal/resolved.html#optional


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk edited a comment on issue #20300: Add Github provider

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #20300:
URL: https://github.com/apache/airflow/issues/20300#issuecomment-996197179


   Alll providers - by definition - are optional features of Airflow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org