You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "rootvector2 (via GitHub)" <gi...@apache.org> on 2026/07/01 13:14:37 UTC
[PR] stop narrowing BigInteger and BigDecimal in StringLocaleConverter [commons-beanutils]
rootvector2 opened a new pull request, #408:
URL: https://github.com/apache/commons-beanutils/pull/408
`StringLocaleConverter.parse` formatted `BigInteger` via `((Number) value).longValue()` and `BigDecimal` via `doubleValue()`, so a value wider than 64 bits was narrowed before formatting and came back silently wrong (`new BigInteger("99999999999999999999")` formatted to `7,766,279,631,452,241,919`); `DecimalFormat.format(Object)` handles `BigInteger`/`BigDecimal` with full magnitude natively, so I format those two types directly and keep the `long`/`double` path for the primitive wrappers. Found while auditing the locale converters against the magnitude handling in `BigIntegerLocaleConverter`/`BigDecimalLocaleConverter`.
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI).
- [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
- [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
- [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Stop narrowing BigInteger and BigDecimal in StringLocaleConverter [commons-beanutils]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #408:
URL: https://github.com/apache/commons-beanutils/pull/408#issuecomment-4860914755
Hi @rootvector2
Thank you for the PR, merged; please port to the `1.X` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Stop narrowing BigInteger and BigDecimal in StringLocaleConverter [commons-beanutils]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #408:
URL: https://github.com/apache/commons-beanutils/pull/408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org