[jira] [Commented] (HAWQ-169) pg_dumpall has wrong filespace sql and ignored the tablespace configuration for database.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HAWQ-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091616#comment-15091616 ] 

ASF GitHub Bot commented on HAWQ-169:
-------------------------------------

GitHub user liming01 opened a pull request:

    https://github.com/apache/incubator-hawq/pull/255

    HAWQ-169. Dump filespace syntax changed.

    Now we don't support specifying different URL for different segments, so CREATE FILESPACE syntax changed, we don't need to print 'dbid:' any more. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liming01/incubator-hawq mli/dump_fs_sql

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/255.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #255
    
----
commit a2ab75be8f4f93fbcb053f80539ca572972dc004
Author: Ming LI <ml...@pivotal.io>
Date:   2016-01-11T08:44:12Z

    HAWQ-169. Dump filespace syntax changed.

----


> pg_dumpall has wrong filespace sql and ignored the tablespace configuration for database.
> -----------------------------------------------------------------------------------------
>
>                 Key: HAWQ-169
>                 URL: https://issues.apache.org/jira/browse/HAWQ-169
>             Project: Apache HAWQ
>          Issue Type: Bug
>          Components: Command Line Tools
>            Reporter: Dong Li
>            Assignee: Lei Chang
>
> {code}
> create filespace fsfordump on hdfs ('localhost:8020/fsfordump');
> create TABLESPACE tsfordump FILESPACE fsfordump;
> create database dbfordum TABLESPACE tsfordump;
> \c dbfordum
> create TABLE tablefordum (i int) tablespace tsfordump;
> insert into tablefordum select generate_series(1,100000);
> \q
> {code}
> mkdir bkup
> pg_dumpall -F > ./bkup/datawithfs
> {code}
> drop DATABASE dbfordum ;
> drop TABLESPACE tsfordump ;
> DROP FILESPACE fsfordump;
> {code}
> psql -d postgres ./bkup/datawithfs
> The filespace can't be created successfully.
> when we vi ./bkup/datawithfs, the contents are as follows.
> {code}
> --
> -- Filespaces
> --
> CREATE FILESPACE dfs_system OWNER intern ON hdfs (
>   0: 'localhost:8020/hawq_default'
> ) WITH (NUMREPLICA = 0);
> CREATE FILESPACE fsfordump OWNER intern ON hdfs (
>   0: 'localhost:8020/fsfordump'
> ) WITH (NUMREPLICA = 0);
> --
> -- Tablespaces
> --
> CREATE TABLESPACE tsfordump OWNER intern FILESPACE fsfordump;
> --
> -- Database creation
> --
> CREATE DATABASE dbfordum WITH TEMPLATE = template1 OWNER = intern ENCODING = 'UTF8';
> {code}
> The filespace sql is not correct and the database sql does contain the tablespace information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)