You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/02/10 17:10:31 UTC
Change in hyracks[master]: Fixed a Bug in the Register Node Work
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/624
Change subject: Fixed a Bug in the Register Node Work
......................................................................
Fixed a Bug in the Register Node Work
When registering a node, in order to allow multiple nodes to
share an ip address, we store them in a map <ipaddress,List<nodeNames>>
However, the way we check for the existence of an entry had a bug in it
which causes the entry to never be found.
Change-Id: I39273c2d72cee0f85187febc9a2b1a6086181e66
---
M hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/hyracks refs/changes/24/624/1
diff --git a/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java b/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
index 7ac0641..dd26ea4 100644
--- a/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
+++ b/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
@@ -72,7 +72,7 @@
}
ncConfiguration = new HashMap<String, String>();
state.getNCConfig().toMap(ncConfiguration);
- Set<String> nodes = ipAddressNodeNameMap.get(ipAddress);
+ Set<String> nodes = ipAddressNodeNameMap.get(InetAddress.getByName(ipAddress));
if (nodes == null) {
nodes = new HashSet<String>();
ipAddressNodeNameMap.put(InetAddress.getByName(ipAddress), nodes);
--
To view, visit https://asterix-gerrit.ics.uci.edu/624
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39273c2d72cee0f85187febc9a2b1a6086181e66
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Change in hyracks[master]: Fixed a Bug in the Register Node Work
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Fixed a Bug in the Register Node Work
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/796/
--
To view, visit https://asterix-gerrit.ics.uci.edu/624
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39273c2d72cee0f85187febc9a2b1a6086181e66
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in hyracks[master]: Fixed a Bug in the Register Node Work
Posted by "Ian Maxon (Code Review)" <do...@asterixdb.incubator.apache.org>.
Ian Maxon has posted comments on this change.
Change subject: Fixed a Bug in the Register Node Work
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/624
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39273c2d72cee0f85187febc9a2b1a6086181e66
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in hyracks[master]: Fixed a Bug in the Register Node Work
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: Fixed a Bug in the Register Node Work
......................................................................
Patch Set 1: Verified+1
Build Successful
https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/796/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/624
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39273c2d72cee0f85187febc9a2b1a6086181e66
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in hyracks[master]: Fixed a Bug in the Register Node Work
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has submitted this change and it was merged.
Change subject: Fixed a Bug in the Register Node Work
......................................................................
Fixed a Bug in the Register Node Work
When registering a node, in order to allow multiple nodes to
share an ip address, we store them in a map <ipaddress,List<nodeNames>>
However, the way we check for the existence of an entry had a bug in it
which causes the entry to never be found.
Change-Id: I39273c2d72cee0f85187febc9a2b1a6086181e66
Reviewed-on: https://asterix-gerrit.ics.uci.edu/624
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Ian Maxon <im...@apache.org>
---
M hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ian Maxon: Looks good to me, approved
Jenkins: Verified
diff --git a/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java b/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
index 7ac0641..dd26ea4 100644
--- a/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
+++ b/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
@@ -72,7 +72,7 @@
}
ncConfiguration = new HashMap<String, String>();
state.getNCConfig().toMap(ncConfiguration);
- Set<String> nodes = ipAddressNodeNameMap.get(ipAddress);
+ Set<String> nodes = ipAddressNodeNameMap.get(InetAddress.getByName(ipAddress));
if (nodes == null) {
nodes = new HashSet<String>();
ipAddressNodeNameMap.put(InetAddress.getByName(ipAddress), nodes);
--
To view, visit https://asterix-gerrit.ics.uci.edu/624
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I39273c2d72cee0f85187febc9a2b1a6086181e66
Gerrit-PatchSet: 2
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <ba...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>