[GitHub] [airflow] ashb commented on a change in pull request #15945: Extract database options to new section

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #15945:
URL: https://github.com/apache/airflow/pull/15945#discussion_r637550804



##########
File path: UPDATING.md
##########
@@ -84,6 +84,23 @@ Previously this was controlled by `non_pooled_task_slot_count` in `[core]` secti
 
 ## Airflow 2.1.0
 
+### Database configuration has been moved to new section
+
+The following configurations have been moved from `[core]` to the new `[database]` section.

Review comment:
       How about db for shorter env vars? `AIRFLOW__DB_*`

##########
File path: UPDATING.md
##########
@@ -84,6 +84,23 @@ Previously this was controlled by `non_pooled_task_slot_count` in `[core]` secti
 
 ## Airflow 2.1.0
 
+### Database configuration has been moved to new section
+
+The following configurations have been moved from `[core]` to the new `[database]` section.
+
+- `sql_alchemy_conn`
+- `sql_engine_encoding`
+- `sql_engine_collation_for_ids`
+- `sql_alchemy_pool_enabled`
+- `sql_alchemy_pool_size`
+- `sql_alchemy_max_overflow`
+- `sql_alchemy_pool_recycle`
+- `sql_alchemy_pool_pre_ping`
+- `sql_alchemy_schema`
+- `sql_alchemy_connect_args`

Review comment:
       Ditto here, if they are in a dedicated section then `sql`/`sql_alchemy` prefix is largely redundant now

##########
File path: UPDATING.md
##########
@@ -84,6 +84,23 @@ Previously this was controlled by `non_pooled_task_slot_count` in `[core]` secti
 
 ## Airflow 2.1.0
 
+### Database configuration has been moved to new section
+
+The following configurations have been moved from `[core]` to the new `[database]` section.
+
+- `sql_alchemy_conn`

Review comment:
       If we are renaming this lets go all the way, and just make this uri? `AIRFLOW__DB__URI`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org