You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by rb...@apache.org on 2002/05/29 01:14:15 UTC
cvs commit: httpd-2.0/modules/mappers mod_userdir.c
rbb 02/05/28 16:14:15
Modified: modules/mappers mod_userdir.c
Log:
Fix http redirecting for UserDir. Before this patch, the directive:
UserDir http://www.foo.com/~*/
The code would ignore the http:// and instead use the user's home directory
Revision Changes Path
1.48 +2 -2 httpd-2.0/modules/mappers/mod_userdir.c
Index: mod_userdir.c
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/mappers/mod_userdir.c,v
retrieving revision 1.47
retrieving revision 1.48
diff -u -r1.47 -r1.48
--- mod_userdir.c 7 May 2002 00:17:11 -0000 1.47
+++ mod_userdir.c 28 May 2002 23:14:15 -0000 1.48
@@ -317,8 +317,8 @@
else
filename = apr_pstrcat(r->pool, userdir, "/", w, NULL);
}
- else if (ap_strchr_c(userdir, ':')) {
- redirect = apr_pstrcat(r->pool, userdir, "/", w, dname, NULL);
+ else if (ap_strchr_c(x, ':')) {
+ redirect = apr_pstrcat(r->pool, x, w, dname, NULL);
apr_table_setn(r->headers_out, "Location", redirect);
return HTTP_MOVED_TEMPORARILY;
}
RE: cvs commit: httpd-2.0/modules/mappers mod_userdir.c
Posted by Ryan Bloom <rb...@covalent.net>.
> From: Cliff Woolley [mailto:jwoolley@virginia.edu]
>
> On 28 May 2002 rbb@apache.org wrote:
>
> > rbb 02/05/28 16:14:15
> >
> > Modified: modules/mappers mod_userdir.c
> > Log:
> > Fix http redirecting for UserDir. Before this patch, the
directive:
> > UserDir http://www.foo.com/~*/
> > The code would ignore the http:// and instead use the user's home
> directory
>
> Cool, thanks. Since you've looked at this code recently, any thoughts
on
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9299 and the patch
> therein?
The code is ugly as it stands now. I will try to look at it tonight and
clean it up. I just needed this fix ASAP, so I committed it. I'll do
the rest of the cleanup later, as a part of that cleanup, I'll implement
the path that the patch addresses.
Ryan
Re: cvs commit: httpd-2.0/modules/mappers mod_userdir.c
Posted by Cliff Woolley <jw...@virginia.edu>.
On 28 May 2002 rbb@apache.org wrote:
> rbb 02/05/28 16:14:15
>
> Modified: modules/mappers mod_userdir.c
> Log:
> Fix http redirecting for UserDir. Before this patch, the directive:
> UserDir http://www.foo.com/~*/
> The code would ignore the http:// and instead use the user's home directory
Cool, thanks. Since you've looked at this code recently, any thoughts on
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9299 and the patch
therein?
--Cliff