You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/04 10:14:40 UTC
[jira] [Commented] (FLINK-3567) Rework selection when grouping in
Table API
[ https://issues.apache.org/jira/browse/FLINK-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179596#comment-15179596 ]
ASF GitHub Bot commented on FLINK-3567:
---------------------------------------
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/1761
[FLINK-3567] Fix selection on grouping. Only grouping keys or aggregates allowed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink tableGrouping
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1761.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1761
----
commit 3665f3c5c4dd7681f01d1df7d0e126d932bc893e
Author: Fabian Hueske <fh...@apache.org>
Date: 2016-03-04T08:51:19Z
[FLINK-3567] Fix selection on grouping. Only grouping keys or aggregates allowed.
----
> Rework selection when grouping in Table API
> -------------------------------------------
>
> Key: FLINK-3567
> URL: https://issues.apache.org/jira/browse/FLINK-3567
> Project: Flink
> Issue Type: Bug
> Components: Table API
> Reporter: Timo Walther
> Assignee: Fabian Hueske
>
> {code}table.groupBy("a").select("e"){code}
> does not throw any exception.
> Fabian looked at the implementation of GroupedTable.select() and it looks incorrect. It does not group but just add a selection. Either we should reject the select or select the value an arbitrary row of the group.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)