[GitHub] [nifi] pvillard31 commented on a diff in pull request #7495: NIFI-11828 - Confluent Schema Encoding Access Strategy - Schema ID versus Schema Version ID

["pvillard31 (via GitHub)" <gi...@apache.org>]

pvillard31 commented on code in PR #7495:
URL: https://github.com/apache/nifi/pull/7495#discussion_r1267906373


##########
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/schema/access/ConfluentSchemaRegistryStrategy.java:
##########
@@ -67,7 +67,7 @@ public RecordSchema getSchema(final Map<String, String> variables, final InputSt
         final int schemaId = bb.getInt();
 
         final SchemaIdentifier schemaIdentifier = SchemaIdentifier.builder()
-                .id(Long.valueOf(schemaId))
+                .schemaVersionId(Long.valueOf(schemaId))
                 .version(1)

Review Comment:
   yep, that's fair, I don't see this version 1 used anywhere - I pushed a commit to remove it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org