You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by paul-guo- <gi...@git.apache.org> on 2016/07/01 02:40:24 UTC
[GitHub] incubator-hawq pull request #763: HAWQ-885. Should fail earlier at creating ...
GitHub user paul-guo- opened a pull request:
https://github.com/apache/incubator-hawq/pull/763
HAWQ-885. Should fail earlier at creating for a table with quicklz co\u2026
\u2026mpression.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-guo-/incubator-hawq snappy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/763.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #763
----
commit 4f39857f152646c4fe854d31b5eb92036d2c50bc
Author: Paul Guo <pa...@gmail.com>
Date: 2016-07-01T02:35:26Z
HAWQ-885. Should fail earlier at creating for a table with quicklz compression.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #763: HAWQ-885. Should fail earlier at creating ...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/763#discussion_r69244453
--- Diff: src/backend/access/common/reloptions.c ---
@@ -515,22 +515,20 @@ default_reloptions(Datum reloptions, bool validate, char relkind,
compresstype = values[5];
--- End diff --
The code is not just for hacking here. Even we remove quicklz from system tables in the future, this code could be still kept to educate users for some time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #763: HAWQ-885. Should fail earlier at creating for a t...
Posted by wengyanqing <gi...@git.apache.org>.
Github user wengyanqing commented on the issue:
https://github.com/apache/incubator-hawq/pull/763
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #763: HAWQ-885. Should fail earlier at creating for a t...
Posted by ztao1987 <gi...@git.apache.org>.
Github user ztao1987 commented on the issue:
https://github.com/apache/incubator-hawq/pull/763
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #763: HAWQ-885. Should fail earlier at creating ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/763
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #763: HAWQ-885. Should fail earlier at creating ...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/763#discussion_r69242660
--- Diff: src/backend/access/common/reloptions.c ---
@@ -515,22 +515,20 @@ default_reloptions(Datum reloptions, bool validate, char relkind,
compresstype = values[5];
--- End diff --
The fix should remove quicklz from valid compression type list. It is better to add comment here we reserve quicklz in catalog for ease of upgrade.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---