[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4117: feat: support `Interval` + `Timestamp` and `Interval` + `Date`

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #4117:
URL: https://github.com/apache/arrow-rs/pull/4117#discussion_r1175574933


##########
arrow-arith/src/arithmetic.rs:
##########
@@ -838,6 +838,13 @@ pub fn add_dyn(left: &dyn Array, right: &dyn Array) -> Result<ArrayRef, ArrowErr
                 ))),
             }
         }
+
+        DataType::Interval(_)
+            if right.data_type().is_temporal()
+                && left.data_type() != right.data_type() =>

Review Comment:
   I think this will recurse indefinitely if given two interval types with different `IntervalUnit`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org