[GitHub] [tvm] huajsj commented on pull request #11405: [Runtime][PipelineExecutor] Move graph_split into relay testing.

[GitBox <gi...@apache.org>]

huajsj commented on PR #11405:
URL: https://github.com/apache/tvm/pull/11405#issuecomment-1134931206

   > I think it's better to keep this function in a pipeline executor test file. Things under `relay.testing` are supposed to be generally useful. And you need to add documentation and improve code quality if you want others to use this code.
   
   @masahi, thanks for the follow up, I do see some requirement for a solution to handle graph splitting for example in this discussion(https://discuss.tvm.apache.org/t/relay-generate-sub-graphs-from-existing-graph/11594), as a short term solution, this graph_split function can serve as an example and a python level support,  I think that should be useful to separate this function into 'relay.testing' to let others use it, for sure I will add documentation and polish the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org