You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/07 01:53:55 UTC
[GitHub] [superset] shawnzhu opened a new pull request #15010: fix: document required information for OAuth2 configuration
shawnzhu opened a new pull request #15010:
URL: https://github.com/apache/superset/pull/15010
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Adding required steps when configuring OAuth2 authentication.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #12855
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a change in pull request #15010: fix: document required information for OAuth2 configuration
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #15010:
URL: https://github.com/apache/superset/pull/15010#discussion_r646227500
##########
File path: docs/src/pages/docs/installation/configuring.mdx
##########
@@ -113,6 +113,8 @@ RequestHeader set X-Forwarded-Proto "https"
Beyond FAB supported providers (Github, Twitter, LinkedIn, Google, Azure, etc), its easy to connect
Superset with other OAuth2 Authorization Server implementations that support “code” authorization.
+Make sure the pip package `Authlib` is installed on the webserver.
Review comment:
Can we link to the pip package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] shawnzhu commented on pull request #15010: docs: required information for OAuth2 configuration
Posted by GitBox <gi...@apache.org>.
shawnzhu commented on pull request #15010:
URL: https://github.com/apache/superset/pull/15010#issuecomment-855526155
@nytai I've added the link to the pip package `authlib`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai merged pull request #15010: docs: required information for OAuth2 configuration
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #15010:
URL: https://github.com/apache/superset/pull/15010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] shawnzhu commented on a change in pull request #15010: docs: required information for OAuth2 configuration
Posted by GitBox <gi...@apache.org>.
shawnzhu commented on a change in pull request #15010:
URL: https://github.com/apache/superset/pull/15010#discussion_r646229244
##########
File path: docs/src/pages/docs/installation/configuring.mdx
##########
@@ -113,6 +113,8 @@ RequestHeader set X-Forwarded-Proto "https"
Beyond FAB supported providers (Github, Twitter, LinkedIn, Google, Azure, etc), its easy to connect
Superset with other OAuth2 Authorization Server implementations that support “code” authorization.
+Make sure the pip package `Authlib` is installed on the webserver.
Review comment:
addressed in https://github.com/apache/superset/pull/15010/commits/bb2253e5a541af60b8777519f401837e27310a22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org