You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2014/11/27 04:54:35 UTC

[GitHub] tajo pull request: TAJO-1209: Pluggable line (de)serializer for De...

GitHub user hyunsik opened a pull request:

    https://github.com/apache/tajo/pull/271

    TAJO-1209: Pluggable line (de)serializer for DelimitedTextFile.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hyunsik/tajo TAJO-1209

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/271.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #271
    
----
commit 7837dde631cb4d66635663b5c80db47a944db044
Author: Hyunsik Choi <hy...@apache.org>
Date:   2014-11-27T03:39:12Z

    TAJO-1209: Pluggable line (de)serializer for DelimitedTextFile.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1209: Pluggable line (de)serializer for De...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/271#issuecomment-64775068
  
    committed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1209: Pluggable line (de)serializer for De...

Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:

    https://github.com/apache/tajo/pull/271#issuecomment-64770248
  
    +1 
    looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1209: Pluggable line (de)serializer for De...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/271#issuecomment-64761757
  
    I've updated the patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1209: Pluggable line (de)serializer for De...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/271#issuecomment-64743403
  
    See the description in https://issues.apache.org/jira/browse/TAJO-1209.
    
    I keep the existing CSVFile class because TAJO-838 needs CSVFile which is a seekable scanner.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1209: Pluggable line (de)serializer for De...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik closed the pull request at:

    https://github.com/apache/tajo/pull/271


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---