You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/27 00:05:33 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0 in testing
dongjoon-hyun opened a new pull request #29252:
URL: https://github.com/apache/spark/pull/29252
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460612995
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1233,7 +1233,7 @@ setMethod("collect",
port = port, blocking = TRUE, open = "wb", timeout = connectionTimeout)
output <- tryCatch({
doServerAuth(conn, authSecret)
- arrowTable <- arrow::read_arrow(readRaw(conn))
+ arrowTable <- arrow::read_ipc_stream(readRaw(conn))
Review comment:
Ah, right, this was added since 0.17.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460609724
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1233,7 +1233,7 @@ setMethod("collect",
port = port, blocking = TRUE, open = "wb", timeout = connectionTimeout)
output <- tryCatch({
doServerAuth(conn, authSecret)
- arrowTable <- arrow::read_arrow(readRaw(conn))
+ arrowTable <- arrow::read_ipc_stream(readRaw(conn))
Review comment:
Jenkins has old Arrow, @HyukjinKwon , and this passed Jenkins~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664077837
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664075396
Thank you for review, @viirya . For `AppVeyor`, it seems to have another issue.
```
[INFO] ------------------------------------------------------------------------
1906[INFO] BUILD SUCCESS
1907[INFO] ------------------------------------------------------------------------
1908[INFO] Total time: 22:38 min
1909[INFO] Finished at: 2020-07-27T01:13:32Z
1910[INFO] ------------------------------------------------------------------------
1911.\bin\spark-submit2.cmd --driver-java-options "-Dlog4j.configuration=file:///%CD:\=/%/R/log4j.properties" --conf spark.hadoop.fs.defaultFS="file:///" R\pkg\tests\run-all.R
1912"Presence of build for multiple Scala versions detected ( and )."
1913"Remove one of them or, set SPARK_SCALA_VERSION= in \spark-env.cmd."
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460612985
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1233,7 +1233,7 @@ setMethod("collect",
port = port, blocking = TRUE, open = "wb", timeout = connectionTimeout)
output <- tryCatch({
doServerAuth(conn, authSecret)
- arrowTable <- arrow::read_arrow(readRaw(conn))
+ arrowTable <- arrow::read_ipc_stream(readRaw(conn))
Review comment:
It exists in arrow_0.17.1.tar. I checked NAMESPACE~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664065415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664077186
I think we could just deal with Arrow in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460613515
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1233,7 +1233,7 @@ setMethod("collect",
port = port, blocking = TRUE, open = "wb", timeout = connectionTimeout)
output <- tryCatch({
doServerAuth(conn, authSecret)
- arrowTable <- arrow::read_arrow(readRaw(conn))
+ arrowTable <- arrow::read_ipc_stream(readRaw(conn))
Review comment:
Maybe increasing minimum Arrow version to 0.17.1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664077686
Oh, thank you so much, @viirya ! Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664065166
**[Test build #126595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126595/testReport)** for PR 29252 at commit [`caacdee`](https://github.com/apache/spark/commit/caacdee058068b7fbeb9a092b39e637ebaa65ef7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460610151
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1233,7 +1233,7 @@ setMethod("collect",
port = port, blocking = TRUE, open = "wb", timeout = connectionTimeout)
output <- tryCatch({
doServerAuth(conn, authSecret)
- arrowTable <- arrow::read_arrow(readRaw(conn))
+ arrowTable <- arrow::read_ipc_stream(readRaw(conn))
Review comment:
Oh.. Jenkins doesn't have arrow? Let me check then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460609008
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1233,7 +1233,7 @@ setMethod("collect",
port = port, blocking = TRUE, open = "wb", timeout = connectionTimeout)
output <- tryCatch({
doServerAuth(conn, authSecret)
- arrowTable <- arrow::read_arrow(readRaw(conn))
+ arrowTable <- arrow::read_ipc_stream(readRaw(conn))
Review comment:
Quick question. When was this API added? R side currently supports Arrow 0.15.1+.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664075396
Thank you for review, @viirya . For `AppVeyor`, it seems to have another issue. I'm thinking of excluding `AppVeyor` from this PR.
```
[INFO] ------------------------------------------------------------------------
1906[INFO] BUILD SUCCESS
1907[INFO] ------------------------------------------------------------------------
1908[INFO] Total time: 22:38 min
1909[INFO] Finished at: 2020-07-27T01:13:32Z
1910[INFO] ------------------------------------------------------------------------
1911.\bin\spark-submit2.cmd --driver-java-options "-Dlog4j.configuration=file:///%CD:\=/%/R/log4j.properties" --conf spark.hadoop.fs.defaultFS="file:///" R\pkg\tests\run-all.R
1912"Presence of build for multiple Scala versions detected ( and )."
1913"Remove one of them or, set SPARK_SCALA_VERSION= in \spark-env.cmd."
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664067635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664065415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460613293
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1233,7 +1233,7 @@ setMethod("collect",
port = port, blocking = TRUE, open = "wb", timeout = connectionTimeout)
output <- tryCatch({
doServerAuth(conn, authSecret)
- arrowTable <- arrow::read_arrow(readRaw(conn))
+ arrowTable <- arrow::read_ipc_stream(readRaw(conn))
Review comment:
For this part, if we are not bump up our minimum, we need to have `if .. else`. Please make a follow up. Thanks, guys.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460604977
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1233,7 +1233,7 @@ setMethod("collect",
port = port, blocking = TRUE, open = "wb", timeout = connectionTimeout)
output <- tryCatch({
doServerAuth(conn, authSecret)
- arrowTable <- arrow::read_arrow(readRaw(conn))
+ arrowTable <- arrow::read_ipc_stream(readRaw(conn))
Review comment:
This looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0 in testing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664059189
**[Test build #126593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126593/testReport)** for PR 29252 at commit [`2df5caf`](https://github.com/apache/spark/commit/2df5caf715629f12495cc5ab1f50c85702023436).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664071797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664065166
**[Test build #126595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126595/testReport)** for PR 29252 at commit [`caacdee`](https://github.com/apache/spark/commit/caacdee058068b7fbeb9a092b39e637ebaa65ef7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29252:
URL: https://github.com/apache/spark/pull/29252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460610804
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1233,7 +1233,7 @@ setMethod("collect",
port = port, blocking = TRUE, open = "wb", timeout = connectionTimeout)
output <- tryCatch({
doServerAuth(conn, authSecret)
- arrowTable <- arrow::read_arrow(readRaw(conn))
+ arrowTable <- arrow::read_ipc_stream(readRaw(conn))
Review comment:
Ah, Jenkins doesn't have one yet. It's true that people will likely use the latest version of Arrow R as R rather aggressively encourages people to use the latest version. I will just make a quick followup with an if-else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664077374
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664059327
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664067492
**[Test build #126593 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126593/testReport)** for PR 29252 at commit [`2df5caf`](https://github.com/apache/spark/commit/2df5caf715629f12495cc5ab1f50c85702023436).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664059485
Hi, @HyukjinKwon .
Could you review this?
This will recover GitHub Action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664077626
I reverted AppVeyor part and updated the PR description. Can we proceed to merge since it's already verified?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664059189
**[Test build #126593 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126593/testReport)** for PR 29252 at commit [`2df5caf`](https://github.com/apache/spark/commit/2df5caf715629f12495cc5ab1f50c85702023436).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460606618
##########
File path: appveyor.yml
##########
@@ -57,6 +57,8 @@ environment:
# "(converted from warning) unable to identify current timezone 'C':" for an unknown reason.
# This environment variable works around to test SparkR against a higher version.
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
+ # AppVeyor doesn't have python3 yet
+ PYSPARK_PYTHON: python
Review comment:
Yes. It has been broken for a while, so the recent `Python3` change is not discovered correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460609852
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1233,7 +1233,7 @@ setMethod("collect",
port = port, blocking = TRUE, open = "wb", timeout = connectionTimeout)
output <- tryCatch({
doServerAuth(conn, authSecret)
- arrowTable <- arrow::read_arrow(readRaw(conn))
+ arrowTable <- arrow::read_ipc_stream(readRaw(conn))
Review comment:
Please note that the failure didn't occurred in Jenkins environment. Only GitHub Action and AppVeyor failed so far.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664068890
Hi, @viirya . Could you review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664059485
Hi, @HyukjinKwon .
Could you review this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664077837
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664071797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664059327
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460616116
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1233,7 +1233,7 @@ setMethod("collect",
port = port, blocking = TRUE, open = "wb", timeout = connectionTimeout)
output <- tryCatch({
doServerAuth(conn, authSecret)
- arrowTable <- arrow::read_arrow(readRaw(conn))
+ arrowTable <- arrow::read_ipc_stream(readRaw(conn))
Review comment:
Let me just bump up the minimal version of Arrow in SparkR at https://github.com/apache/spark/pull/29253. Should be fine since such minimal version bump-up is already documented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460612176
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1233,7 +1233,7 @@ setMethod("collect",
port = port, blocking = TRUE, open = "wb", timeout = connectionTimeout)
output <- tryCatch({
doServerAuth(conn, authSecret)
- arrowTable <- arrow::read_arrow(readRaw(conn))
+ arrowTable <- arrow::read_ipc_stream(readRaw(conn))
Review comment:
Actually, I think we can simply bump up the minimum Arrow version for SparkR specifically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664071710
**[Test build #126595 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126595/testReport)** for PR 29252 at commit [`caacdee`](https://github.com/apache/spark/commit/caacdee058068b7fbeb9a092b39e637ebaa65ef7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460597369
##########
File path: appveyor.yml
##########
@@ -57,6 +57,8 @@ environment:
# "(converted from warning) unable to identify current timezone 'C':" for an unknown reason.
# This environment variable works around to test SparkR against a higher version.
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
+ # AppVeyor doesn't have python3 yet
+ PYSPARK_PYTHON: python
Review comment:
I piggy-backed this because I want to make AppVeyor success in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29252:
URL: https://github.com/apache/spark/pull/29252#issuecomment-664067635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460613100
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1233,7 +1233,7 @@ setMethod("collect",
port = port, blocking = TRUE, open = "wb", timeout = connectionTimeout)
output <- tryCatch({
doServerAuth(conn, authSecret)
- arrowTable <- arrow::read_arrow(readRaw(conn))
+ arrowTable <- arrow::read_ipc_stream(readRaw(conn))
Review comment:
Oh.. It's not 0.15. Got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460605197
##########
File path: appveyor.yml
##########
@@ -57,6 +57,8 @@ environment:
# "(converted from warning) unable to identify current timezone 'C':" for an unknown reason.
# This environment variable works around to test SparkR against a higher version.
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
+ # AppVeyor doesn't have python3 yet
+ PYSPARK_PYTHON: python
Review comment:
hm, so AppVeyor was broken now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29252: [SPARK-32451][R] Support Apache Arrow 1.0.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29252:
URL: https://github.com/apache/spark/pull/29252#discussion_r460610311
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1233,7 +1233,7 @@ setMethod("collect",
port = port, blocking = TRUE, open = "wb", timeout = connectionTimeout)
output <- tryCatch({
doServerAuth(conn, authSecret)
- arrowTable <- arrow::read_arrow(readRaw(conn))
+ arrowTable <- arrow::read_ipc_stream(readRaw(conn))
Review comment:
BTW, I believe Apache Spark 3.1 can have Arrow 1.0.0 of course, but we have also a pinning PR if we want.
- https://github.com/apache/spark/pull/29251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org