You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/11/29 01:11:40 UTC

[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #578: [IOTDB-311]Generate anything in test to the target directory.

samperson1997 commented on a change in pull request #578: [IOTDB-311]Generate anything in test to the target directory.
URL: https://github.com/apache/incubator-iotdb/pull/578#discussion_r351951226
 
 

 ##########
 File path: hadoop/src/test/java/org/apache/iotdb/hadoop/tsfile/TSFHadoopTest.java
 ##########
 @@ -38,7 +39,7 @@
 
   private TSFInputFormat inputFormat = null;
 
-  private String tsfilePath = "example_mr.tsfile";
+  private String tsfilePath = TestConstant.BASE_OUTPUT_PATH.concat("example_mr.tsfile");
 
 Review comment:
   Actually I think "+" is enough for strings concat... Do you think it is necessary to change it to be consist with other place in the project?  @qiaojialin 
   ```suggestion
     private String tsfilePath = TestConstant.BASE_OUTPUT_PATH + "example_mr.tsfile";
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services