You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/25 05:29:22 UTC
[GitHub] [flink] yangyichao-mango opened a new pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
yangyichao-mango opened a new pull request #12313:
URL: https://github.com/apache/flink/pull/12313
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Translate the CREATE TABLE ... LIKE syntax documentation to Chinese*
## Brief change log
- *Updating the docs/dev/table/sql/create.zh.md*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong closed pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #12313:
URL: https://github.com/apache/flink/pull/12313
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633562437
Thx. I've rebase that commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on a change in pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on a change in pull request #12313:
URL: https://github.com/apache/flink/pull/12313#discussion_r431091182
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -208,14 +215,14 @@ CREATE TABLE Orders (
**注意：** 使用 `CREATE TABLE` 语句注册的表均可用作 table source 和 table sink。 在被 DML 语句引用前，我们无法决定其实际用于 source 抑或是 sink。
-**LIKE clause**
+**LIKE**
+
+`LIKE` 子句来源于两种 SQL 特性的变体/组合（Feature T171，“表定义中的LIKE语法” 和 Feature T173，“表定义中的LIKE语法扩展”）。LIKE 子句可以基于现有表的定义去创建新表，并且可以扩展或排除原始表中的某些部分。与 SQL 标准相反，LIKE 子句必须在 CREATE 语句中定义。这是因为 LIKE 子句可以应用于表定义的多个部分，而不仅仅是 schema 部分。
-The `LIKE` clause is a variant/combination of SQL features (Feature T171, “LIKE clause in table definition” and Feature T173, “Extended LIKE clause in table definition”). The clause can be used to create a table based on a definition of an existing table. Additionally, users
-can extend the original table or exclude certain parts of it. In contrast to the SQL standard the clause must be defined at the top-level of a CREATE statement. That is because the clause applies to multiple parts of the definition and not only to the schema part.
+你可以使用该子句，重用（或覆写）指定的连接器配置属性或者可以向外部表添加 watermark 定义，例如可以向 Apache Hive 中定义的表添加 watermark 定义。
Review comment:
表的watermark定义也是可以使用like子句更改，所以这部分我理解指的不仅仅是读取可能是没有 watermark 的，我理解是无论是否定义过，都可以添加
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on a change in pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on a change in pull request #12313:
URL: https://github.com/apache/flink/pull/12313#discussion_r431091474
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -249,59 +257,60 @@ CREATE TABLE Orders_with_watermark (
);
{% endhighlight %}
-The merging logic of table features can be controlled with `like options`.
+表属性的合并逻辑可以用 `like options` 来控制。
-You can control the merging behavior of:
+可以控制合并的表属性如下：
-* CONSTRAINTS - constraints such as primary and unique keys
-* GENERATED - computed columns
-* OPTIONS - connector options that describe connector and format properties
-* PARTITIONS - partition of the tables
-* WATERMARKS - watermark declarations
+* CONSTRAINTS - 主键和唯一键约束
+* GENERATED - 计算列
+* OPTIONS - 连接器和格式化的配置项
Review comment:
嗯嗯，这部分我再思考下
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on a change in pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on a change in pull request #12313:
URL: https://github.com/apache/flink/pull/12313#discussion_r431082900
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -208,14 +215,14 @@ CREATE TABLE Orders (
**注意：** 使用 `CREATE TABLE` 语句注册的表均可用作 table source 和 table sink。 在被 DML 语句引用前，我们无法决定其实际用于 source 抑或是 sink。
-**LIKE clause**
+**LIKE**
+
+`LIKE` 子句来源于两种 SQL 特性的变体/组合（Feature T171，“表定义中的LIKE语法” 和 Feature T173，“表定义中的LIKE语法扩展”）。LIKE 子句可以基于现有表的定义去创建新表，并且可以扩展或排除原始表中的某些部分。与 SQL 标准相反，LIKE 子句必须在 CREATE 语句中定义。这是因为 LIKE 子句可以应用于表定义的多个部分，而不仅仅是 schema 部分。
Review comment:
> 另外这里的实现细节我不是太清楚，但是从字面上看 “at the top-level of a CREATE statement" 这里翻译成”必须在 CREATE 语句中定义“，我比较好奇这里说的 ”top-level“ 是指什么意思呢？
这里的”top-level“我理解是用来形容create table这个语句的，类似于DDL对比与DML是”top-level“，所以我使用了必须在 CREATE 语句中定义“这样的描述
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
}, {
"hash" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144",
"triggerID" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"triggerType" : "PUSH"
}, {
"hash" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 07ab8aa279380cc6584c9602a1c344dfb2294074 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144)
* b67b757ed5193ab53f899e9501e4ce96551f8c40 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
}, {
"hash" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144",
"triggerID" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"triggerType" : "PUSH"
}, {
"hash" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2312",
"triggerID" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"triggerType" : "PUSH"
}, {
"hash" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2603",
"triggerID" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"triggerType" : "PUSH"
}, {
"hash" : "e7dd7fa0fbbab91117bea70ac0c042e08d0637a8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e7dd7fa0fbbab91117bea70ac0c042e08d0637a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05c952fdab2c5cf05b70fa26bd7049a827d06149 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2603)
* e7dd7fa0fbbab91117bea70ac0c042e08d0637a8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
}, {
"hash" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144",
"triggerID" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"triggerType" : "PUSH"
}, {
"hash" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2312",
"triggerID" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 07ab8aa279380cc6584c9602a1c344dfb2294074 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144)
* b67b757ed5193ab53f899e9501e4ce96551f8c40 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2312)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on a change in pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on a change in pull request #12313:
URL: https://github.com/apache/flink/pull/12313#discussion_r431088645
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -208,14 +215,14 @@ CREATE TABLE Orders (
**注意：** 使用 `CREATE TABLE` 语句注册的表均可用作 table source 和 table sink。 在被 DML 语句引用前，我们无法决定其实际用于 source 抑或是 sink。
-**LIKE clause**
+**LIKE**
+
+`LIKE` 子句来源于两种 SQL 特性的变体/组合（Feature T171，“表定义中的LIKE语法” 和 Feature T173，“表定义中的LIKE语法扩展”）。LIKE 子句可以基于现有表的定义去创建新表，并且可以扩展或排除原始表中的某些部分。与 SQL 标准相反，LIKE 子句必须在 CREATE 语句中定义。这是因为 LIKE 子句可以应用于表定义的多个部分，而不仅仅是 schema 部分。
Review comment:
> 另外这里的实现细节我不是太清楚，但是从字面上看 “at the top-level of a CREATE statement" 这里翻译成”必须在 CREATE 语句中定义“，我比较好奇这里说的 ”top-level“ 是指什么意思呢？
这里的”top-level“我原本理解是用来形容create table的，类似于DDL对比与DML是”top-level“，所以我使用了“必须在 CREATE 语句中定义“这样的描述。
现在我有一些不同的理解：对比于create table，like字句是一个更上层的定义方式
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on a change in pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on a change in pull request #12313:
URL: https://github.com/apache/flink/pull/12313#discussion_r431096627
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -249,59 +257,60 @@ CREATE TABLE Orders_with_watermark (
);
{% endhighlight %}
-The merging logic of table features can be controlled with `like options`.
+表属性的合并逻辑可以用 `like options` 来控制。
-You can control the merging behavior of:
+可以控制合并的表属性如下：
-* CONSTRAINTS - constraints such as primary and unique keys
-* GENERATED - computed columns
-* OPTIONS - connector options that describe connector and format properties
-* PARTITIONS - partition of the tables
-* WATERMARKS - watermark declarations
+* CONSTRAINTS - 主键和唯一键约束
+* GENERATED - 计算列
+* OPTIONS - 连接器和格式化的配置项
+* PARTITIONS - 表分区信息
+* WATERMARKS - watermark 定义
-with three different merging strategies:
+并且有三种不同的表属性合并策略：
-* INCLUDING - Includes the feature of the source table, fails on duplicate entries, e.g. if an option with the same key exists in both tables.
-* EXCLUDING - Does not include the given feature of the source table.
-* OVERWRITING - Includes the feature of the source table, overwrites duplicate entries of the source table with properties of the new table, e.g. if an option with the same key exists in both tables, the one from the current statement will be used.
+* INCLUDING - 新表包含源表（source table）所有的表属性，如果和源表的表属性重复则会直接失败，例如新表和源表存在相同 key 的属性。
+* EXCLUDING - 新表不包含源表指定的任何表属性。
+* OVERWRITING - 新表包含源表的表属性，但如果出现重复项，则会用新表的表属性覆盖源表中的重复表属性，例如，两个表中都存在相同 key 的属性，则会使用当前语句中定义的 key 的属性值。
-Additionally, you can use the `INCLUDING/EXCLUDING ALL` option to specify what should be the strategy if there was no specific strategy defined, i.e. if you use `EXCLUDING ALL INCLUDING WATERMARKS` only the watermarks will be included from the source table.
+此外，如果没有特别指定合并策略，也可以使用 `INCLUDING/EXCLUDING ALL` 这种声明方式来指定使用怎样的合并策略，例如使用 `EXCLUDING ALL INCLUDING WATERMARKS`，那么代表只有源表的 WATERMARKS 属性才会被包含进新表。
-Example:
+示例如下：
{% highlight sql %}
--- A source table stored in a filesystem
+
+-- 存储在文件系统的源表
CREATE TABLE Orders_in_file (
user BIGINT,
product STRING,
order_time_string STRING,
order_time AS to_timestamp(order_time)
-
+
)
PARTITIONED BY user
WITH (
'connector' = 'filesystem'
'path' = '...'
);
--- A corresponding table we want to store in kafka
+-- 对应存储在 kafka 的源表
CREATE TABLE Orders_in_kafka (
- -- Add watermark definition
+ -- 添加 watermark 定义
WATERMARK FOR order_time AS order_time - INTERVAL '5' SECOND
) WITH (
'connector': 'kafka'
...
)
LIKE Orders_in_file (
- -- Exclude everything besides the computed columns which we need to generate the watermark for.
- -- We do not want to have the partitions or filesystem options as those do not apply to kafka.
+ -- 排除需要生成 watermark 的计算列之外的所有内容。
+ -- 去除不适用于 kafka 的所有分区和文件系统的相关属性。
EXCLUDING ALL
INCLUDING GENERATED
);
{% endhighlight %}
-If you provide no like options, `INCLUDING ALL OVERWRITING OPTIONS` will be used as a default.
+如果未提供 like 配置项（like options），默认将使用 `INCLUDING ALL OVERWRITING OPTIONS` 的合并策略。
-**NOTE** You cannot control the behavior of merging physical fields. Those will be merged as if you applied the `INCLUDING` strategy.
+**注意：** 您无法选择物理列的合并策略，当物理列进行合并时就如使用了 `INCLUDING` 策略。
Review comment:
这里是参考了当前章节中之前段落对这里的翻译是叫做”物理列“，我理解
物理列指的是表中物理存储的那些列
计算列是使用同一表中其他列的非查询表达式生成，并且不会在表中进行物理存储的列
这里是相互对应的。
如果我理解有问题，希望可以指正，感谢。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
klion26 commented on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-644519136
@yangyichao-mango thanks for the work, could you please use `git rebase` instead of `git merge` to resolve the conflict.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
}, {
"hash" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144",
"triggerID" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"triggerType" : "PUSH"
}, {
"hash" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2312",
"triggerID" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"triggerType" : "PUSH"
}, {
"hash" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2603",
"triggerID" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"triggerType" : "PUSH"
}, {
"hash" : "e7dd7fa0fbbab91117bea70ac0c042e08d0637a8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3555",
"triggerID" : "e7dd7fa0fbbab91117bea70ac0c042e08d0637a8",
"triggerType" : "PUSH"
}, {
"hash" : "9f7c35da7243b25573d4d4d898b8f72ac9589cb8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3631",
"triggerID" : "9f7c35da7243b25573d4d4d898b8f72ac9589cb8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e7dd7fa0fbbab91117bea70ac0c042e08d0637a8 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3555)
* 9f7c35da7243b25573d4d4d898b8f72ac9589cb8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3631)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
}, {
"hash" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144",
"triggerID" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"triggerType" : "PUSH"
}, {
"hash" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2312",
"triggerID" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"triggerType" : "PUSH"
}, {
"hash" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2603",
"triggerID" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"triggerType" : "PUSH"
}, {
"hash" : "e7dd7fa0fbbab91117bea70ac0c042e08d0637a8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3555",
"triggerID" : "e7dd7fa0fbbab91117bea70ac0c042e08d0637a8",
"triggerType" : "PUSH"
}, {
"hash" : "9f7c35da7243b25573d4d4d898b8f72ac9589cb8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3631",
"triggerID" : "9f7c35da7243b25573d4d4d898b8f72ac9589cb8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9f7c35da7243b25573d4d4d898b8f72ac9589cb8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3631)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
}, {
"hash" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144",
"triggerID" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"triggerType" : "PUSH"
}, {
"hash" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2312",
"triggerID" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"triggerType" : "PUSH"
}, {
"hash" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2603",
"triggerID" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b67b757ed5193ab53f899e9501e4ce96551f8c40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2312)
* 05c952fdab2c5cf05b70fa26bd7049a827d06149 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2603)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c225fa8b2a774a8579501e136004a9d64db89244 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-644513011
> @yangyichao-mango Seems there are some conflicts need to be resolved, could you please rebase the new master to resolve them?
Thx a lot. I've resolved those conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-636319794
I've pushed a new commit to apply all of the suggestions.
Thx for review. @klion26
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
}, {
"hash" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144",
"triggerID" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c225fa8b2a774a8579501e136004a9d64db89244 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108)
* 07ab8aa279380cc6584c9602a1c344dfb2294074 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on a change in pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #12313:
URL: https://github.com/apache/flink/pull/12313#discussion_r430865901
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -208,14 +215,14 @@ CREATE TABLE Orders (
**注意：** 使用 `CREATE TABLE` 语句注册的表均可用作 table source 和 table sink。 在被 DML 语句引用前，我们无法决定其实际用于 source 抑或是 sink。
-**LIKE clause**
+**LIKE**
+
+`LIKE` 子句来源于两种 SQL 特性的变体/组合（Feature T171，“表定义中的LIKE语法” 和 Feature T173，“表定义中的LIKE语法扩展”）。LIKE 子句可以基于现有表的定义去创建新表，并且可以扩展或排除原始表中的某些部分。与 SQL 标准相反，LIKE 子句必须在 CREATE 语句中定义。这是因为 LIKE 子句可以应用于表定义的多个部分，而不仅仅是 schema 部分。
Review comment:
```suggestion
`LIKE` 子句来源于两种 SQL 特性的变体/组合（Feature T171，“表定义中的 LIKE 语法” 和 Feature T173，“表定义中的 LIKE 语法扩展”）。LIKE 子句可以基于现有表的定义去创建新表，并且可以扩展或排除原始表中的某些部分。与 SQL 标准相反，LIKE 子句必须在 CREATE 语句中定义。这是因为 LIKE 子句可以应用于表定义的多个部分，而不仅仅是 schema 部分。
```
另外这里的实现细节我不是太清楚，但是从字面上看 “at the top-level of a CREATE statement" 这里翻译成”必须在 CREATE 语句中定义“，我比较好奇这里说的 ”top-level“ 是指什么意思呢？
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -208,14 +215,14 @@ CREATE TABLE Orders (
**注意：** 使用 `CREATE TABLE` 语句注册的表均可用作 table source 和 table sink。 在被 DML 语句引用前，我们无法决定其实际用于 source 抑或是 sink。
-**LIKE clause**
+**LIKE**
Review comment:
这里单纯的用 `LIKE` 会觉的不太完整
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -249,59 +257,60 @@ CREATE TABLE Orders_with_watermark (
);
{% endhighlight %}
-The merging logic of table features can be controlled with `like options`.
+表属性的合并逻辑可以用 `like options` 来控制。
-You can control the merging behavior of:
+可以控制合并的表属性如下：
-* CONSTRAINTS - constraints such as primary and unique keys
-* GENERATED - computed columns
-* OPTIONS - connector options that describe connector and format properties
-* PARTITIONS - partition of the tables
-* WATERMARKS - watermark declarations
+* CONSTRAINTS - 主键和唯一键约束
+* GENERATED - 计算列
+* OPTIONS - 连接器和格式化的配置项
+* PARTITIONS - 表分区信息
+* WATERMARKS - watermark 定义
-with three different merging strategies:
+并且有三种不同的表属性合并策略：
-* INCLUDING - Includes the feature of the source table, fails on duplicate entries, e.g. if an option with the same key exists in both tables.
-* EXCLUDING - Does not include the given feature of the source table.
-* OVERWRITING - Includes the feature of the source table, overwrites duplicate entries of the source table with properties of the new table, e.g. if an option with the same key exists in both tables, the one from the current statement will be used.
+* INCLUDING - 新表包含源表（source table）所有的表属性，如果和源表的表属性重复则会直接失败，例如新表和源表存在相同 key 的属性。
+* EXCLUDING - 新表不包含源表指定的任何表属性。
+* OVERWRITING - 新表包含源表的表属性，但如果出现重复项，则会用新表的表属性覆盖源表中的重复表属性，例如，两个表中都存在相同 key 的属性，则会使用当前语句中定义的 key 的属性值。
-Additionally, you can use the `INCLUDING/EXCLUDING ALL` option to specify what should be the strategy if there was no specific strategy defined, i.e. if you use `EXCLUDING ALL INCLUDING WATERMARKS` only the watermarks will be included from the source table.
+此外，如果没有特别指定合并策略，也可以使用 `INCLUDING/EXCLUDING ALL` 这种声明方式来指定使用怎样的合并策略，例如使用 `EXCLUDING ALL INCLUDING WATERMARKS`，那么代表只有源表的 WATERMARKS 属性才会被包含进新表。
-Example:
+示例如下：
{% highlight sql %}
--- A source table stored in a filesystem
+
+-- 存储在文件系统的源表
CREATE TABLE Orders_in_file (
user BIGINT,
product STRING,
order_time_string STRING,
order_time AS to_timestamp(order_time)
-
+
)
PARTITIONED BY user
WITH (
'connector' = 'filesystem'
'path' = '...'
);
--- A corresponding table we want to store in kafka
+-- 对应存储在 kafka 的源表
CREATE TABLE Orders_in_kafka (
- -- Add watermark definition
+ -- 添加 watermark 定义
WATERMARK FOR order_time AS order_time - INTERVAL '5' SECOND
) WITH (
'connector': 'kafka'
...
)
LIKE Orders_in_file (
- -- Exclude everything besides the computed columns which we need to generate the watermark for.
- -- We do not want to have the partitions or filesystem options as those do not apply to kafka.
+ -- 排除需要生成 watermark 的计算列之外的所有内容。
+ -- 去除不适用于 kafka 的所有分区和文件系统的相关属性。
EXCLUDING ALL
INCLUDING GENERATED
);
{% endhighlight %}
-If you provide no like options, `INCLUDING ALL OVERWRITING OPTIONS` will be used as a default.
+如果未提供 like 配置项（like options），默认将使用 `INCLUDING ALL OVERWRITING OPTIONS` 的合并策略。
-**NOTE** You cannot control the behavior of merging physical fields. Those will be merged as if you applied the `INCLUDING` strategy.
+**注意：** 您无法选择物理列的合并策略，当物理列进行合并时就如使用了 `INCLUDING` 策略。
Review comment:
这个有个小疑问，`physical fields` 就是指物理列吗？这个是和 逻辑列 对应的吗？另外在网上搜索发现 “物理列”这个描述好少
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -249,59 +257,60 @@ CREATE TABLE Orders_with_watermark (
);
{% endhighlight %}
-The merging logic of table features can be controlled with `like options`.
+表属性的合并逻辑可以用 `like options` 来控制。
-You can control the merging behavior of:
+可以控制合并的表属性如下：
-* CONSTRAINTS - constraints such as primary and unique keys
-* GENERATED - computed columns
-* OPTIONS - connector options that describe connector and format properties
-* PARTITIONS - partition of the tables
-* WATERMARKS - watermark declarations
+* CONSTRAINTS - 主键和唯一键约束
+* GENERATED - 计算列
+* OPTIONS - 连接器和格式化的配置项
Review comment:
这里 `format properties` 翻译成 `格式化的配置项` 整句话连起来有点像 “`连接器` 和 `格式化的配置项`” 有什么办法可以改进一下吗
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -249,59 +257,60 @@ CREATE TABLE Orders_with_watermark (
);
{% endhighlight %}
-The merging logic of table features can be controlled with `like options`.
+表属性的合并逻辑可以用 `like options` 来控制。
-You can control the merging behavior of:
+可以控制合并的表属性如下：
-* CONSTRAINTS - constraints such as primary and unique keys
-* GENERATED - computed columns
-* OPTIONS - connector options that describe connector and format properties
-* PARTITIONS - partition of the tables
-* WATERMARKS - watermark declarations
+* CONSTRAINTS - 主键和唯一键约束
+* GENERATED - 计算列
+* OPTIONS - 连接器和格式化的配置项
+* PARTITIONS - 表分区信息
+* WATERMARKS - watermark 定义
-with three different merging strategies:
+并且有三种不同的表属性合并策略：
-* INCLUDING - Includes the feature of the source table, fails on duplicate entries, e.g. if an option with the same key exists in both tables.
-* EXCLUDING - Does not include the given feature of the source table.
-* OVERWRITING - Includes the feature of the source table, overwrites duplicate entries of the source table with properties of the new table, e.g. if an option with the same key exists in both tables, the one from the current statement will be used.
+* INCLUDING - 新表包含源表（source table）所有的表属性，如果和源表的表属性重复则会直接失败，例如新表和源表存在相同 key 的属性。
+* EXCLUDING - 新表不包含源表指定的任何表属性。
+* OVERWRITING - 新表包含源表的表属性，但如果出现重复项，则会用新表的表属性覆盖源表中的重复表属性，例如，两个表中都存在相同 key 的属性，则会使用当前语句中定义的 key 的属性值。
-Additionally, you can use the `INCLUDING/EXCLUDING ALL` option to specify what should be the strategy if there was no specific strategy defined, i.e. if you use `EXCLUDING ALL INCLUDING WATERMARKS` only the watermarks will be included from the source table.
+此外，如果没有特别指定合并策略，也可以使用 `INCLUDING/EXCLUDING ALL` 这种声明方式来指定使用怎样的合并策略，例如使用 `EXCLUDING ALL INCLUDING WATERMARKS`，那么代表只有源表的 WATERMARKS 属性才会被包含进新表。
Review comment:
这里的意思是不是说没有一些 “defined” 的策略，那么就可以用 `INCLUDING/EXCLUDING ALL` 类似的语法来描述，就像后面的例子一样。
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -208,14 +215,14 @@ CREATE TABLE Orders (
**注意：** 使用 `CREATE TABLE` 语句注册的表均可用作 table source 和 table sink。 在被 DML 语句引用前，我们无法决定其实际用于 source 抑或是 sink。
-**LIKE clause**
+**LIKE**
+
+`LIKE` 子句来源于两种 SQL 特性的变体/组合（Feature T171，“表定义中的LIKE语法” 和 Feature T173，“表定义中的LIKE语法扩展”）。LIKE 子句可以基于现有表的定义去创建新表，并且可以扩展或排除原始表中的某些部分。与 SQL 标准相反，LIKE 子句必须在 CREATE 语句中定义。这是因为 LIKE 子句可以应用于表定义的多个部分，而不仅仅是 schema 部分。
-The `LIKE` clause is a variant/combination of SQL features (Feature T171, “LIKE clause in table definition” and Feature T173, “Extended LIKE clause in table definition”). The clause can be used to create a table based on a definition of an existing table. Additionally, users
-can extend the original table or exclude certain parts of it. In contrast to the SQL standard the clause must be defined at the top-level of a CREATE statement. That is because the clause applies to multiple parts of the definition and not only to the schema part.
+你可以使用该子句，重用（或覆写）指定的连接器配置属性或者可以向外部表添加 watermark 定义，例如可以向 Apache Hive 中定义的表添加 watermark 定义。
Review comment:
个人意见：`覆写` 更像是繁体中文中的描述，这里如果用 `改写` 会好一些吗？（这里修改的话，其他地方也需要同步修改）
后面这句话的意思是不是说 “可以向哪些从 Apache Hive 读取的表增加 watermark”？ 也就是说从 Hive 读取的，但是仅读取可能是没有 watermark 的，这里就可以增加 watermark
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
klion26 commented on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-643900668
@yangyichao-mango Seems there are some conflicts need to be resolved, could you please rebase the new master to resolve them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
}, {
"hash" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144",
"triggerID" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"triggerType" : "PUSH"
}, {
"hash" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2312",
"triggerID" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b67b757ed5193ab53f899e9501e4ce96551f8c40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2312)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on a change in pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on a change in pull request #12313:
URL: https://github.com/apache/flink/pull/12313#discussion_r431081332
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -208,14 +215,14 @@ CREATE TABLE Orders (
**注意：** 使用 `CREATE TABLE` 语句注册的表均可用作 table source 和 table sink。 在被 DML 语句引用前，我们无法决定其实际用于 source 抑或是 sink。
-**LIKE clause**
+**LIKE**
Review comment:
> 这里单纯的用 `LIKE` 会觉的不太完整
谢谢review~
这里我是为了和整小节的小标题以及create table中的like使用方式保持一致才这样写的，有想过写成【LIKE 子句】，但是个人感觉会比较突兀
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
}, {
"hash" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144",
"triggerID" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"triggerType" : "PUSH"
}, {
"hash" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2312",
"triggerID" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"triggerType" : "PUSH"
}, {
"hash" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2603",
"triggerID" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05c952fdab2c5cf05b70fa26bd7049a827d06149 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2603)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c225fa8b2a774a8579501e136004a9d64db89244 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c225fa8b2a774a8579501e136004a9d64db89244 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633384424
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c225fa8b2a774a8579501e136004a9d64db89244 (Mon May 25 05:32:10 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-644759149
> @yangyichao-mango thanks for the work, could you please use `git rebase` instead of `git merge` to resolve the conflict.
Thx a lot for your review. I've rebased the branch and resolve the conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
}, {
"hash" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144",
"triggerID" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"triggerType" : "PUSH"
}, {
"hash" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2312",
"triggerID" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"triggerType" : "PUSH"
}, {
"hash" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2603",
"triggerID" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"triggerType" : "PUSH"
}, {
"hash" : "e7dd7fa0fbbab91117bea70ac0c042e08d0637a8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3555",
"triggerID" : "e7dd7fa0fbbab91117bea70ac0c042e08d0637a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 05c952fdab2c5cf05b70fa26bd7049a827d06149 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2603)
* e7dd7fa0fbbab91117bea70ac0c042e08d0637a8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3555)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
}, {
"hash" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144",
"triggerID" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"triggerType" : "PUSH"
}, {
"hash" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2312",
"triggerID" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"triggerType" : "PUSH"
}, {
"hash" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2603",
"triggerID" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"triggerType" : "PUSH"
}, {
"hash" : "e7dd7fa0fbbab91117bea70ac0c042e08d0637a8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3555",
"triggerID" : "e7dd7fa0fbbab91117bea70ac0c042e08d0637a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e7dd7fa0fbbab91117bea70ac0c042e08d0637a8 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3555)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
}, {
"hash" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144",
"triggerID" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"triggerType" : "PUSH"
}, {
"hash" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2312",
"triggerID" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"triggerType" : "PUSH"
}, {
"hash" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2603",
"triggerID" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"triggerType" : "PUSH"
}, {
"hash" : "e7dd7fa0fbbab91117bea70ac0c042e08d0637a8",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3555",
"triggerID" : "e7dd7fa0fbbab91117bea70ac0c042e08d0637a8",
"triggerType" : "PUSH"
}, {
"hash" : "9f7c35da7243b25573d4d4d898b8f72ac9589cb8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9f7c35da7243b25573d4d4d898b8f72ac9589cb8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e7dd7fa0fbbab91117bea70ac0c042e08d0637a8 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3555)
* 9f7c35da7243b25573d4d4d898b8f72ac9589cb8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on a change in pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #12313:
URL: https://github.com/apache/flink/pull/12313#discussion_r434312012
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -249,59 +257,60 @@ CREATE TABLE Orders_with_watermark (
);
{% endhighlight %}
-The merging logic of table features can be controlled with `like options`.
+表属性的合并逻辑可以用 `like options` 来控制。
-You can control the merging behavior of:
+可以控制合并的表属性如下：
-* CONSTRAINTS - constraints such as primary and unique keys
-* GENERATED - computed columns
-* OPTIONS - connector options that describe connector and format properties
-* PARTITIONS - partition of the tables
-* WATERMARKS - watermark declarations
+* CONSTRAINTS - 主键和唯一键约束
+* GENERATED - 计算列
+* OPTIONS - 连接器信息、格式化方式等配置项
+* PARTITIONS - 表分区信息
+* WATERMARKS - watermark 定义
-with three different merging strategies:
+并且有三种不同的表属性合并策略：
-* INCLUDING - Includes the feature of the source table, fails on duplicate entries, e.g. if an option with the same key exists in both tables.
-* EXCLUDING - Does not include the given feature of the source table.
-* OVERWRITING - Includes the feature of the source table, overwrites duplicate entries of the source table with properties of the new table, e.g. if an option with the same key exists in both tables, the one from the current statement will be used.
+* INCLUDING - 新表包含源表（source table）所有的表属性，如果和源表的表属性重复则会直接失败，例如新表和源表存在相同 key 的属性。
+* EXCLUDING - 新表不包含源表指定的任何表属性。
+* OVERWRITING - 新表包含源表的表属性，但如果出现重复项，则会用新表的表属性覆盖源表中的重复表属性，例如，两个表中都存在相同 key 的属性，则会使用当前语句中定义的 key 的属性值。
-Additionally, you can use the `INCLUDING/EXCLUDING ALL` option to specify what should be the strategy if there was no specific strategy defined, i.e. if you use `EXCLUDING ALL INCLUDING WATERMARKS` only the watermarks will be included from the source table.
+并且你可以使用 `INCLUDING/EXCLUDING ALL` 这种声明方式来指定使用怎样的合并策略，例如使用 `EXCLUDING ALL INCLUDING WATERMARKS`，那么代表只有源表的 WATERMARKS 属性才会被包含进新表。
-Example:
+示例如下：
{% highlight sql %}
--- A source table stored in a filesystem
+
+-- 存储在文件系统的源表
CREATE TABLE Orders_in_file (
user BIGINT,
product STRING,
order_time_string STRING,
order_time AS to_timestamp(order_time)
-
+
Review comment:
这个无关的修改可以去掉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
}, {
"hash" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c225fa8b2a774a8579501e136004a9d64db89244 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108)
* 07ab8aa279380cc6584c9602a1c344dfb2294074 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-645210419
Thanks @yangyichao-mango and @klion26 , will merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on a change in pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on a change in pull request #12313:
URL: https://github.com/apache/flink/pull/12313#discussion_r434334042
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -249,59 +257,60 @@ CREATE TABLE Orders_with_watermark (
);
{% endhighlight %}
-The merging logic of table features can be controlled with `like options`.
+表属性的合并逻辑可以用 `like options` 来控制。
-You can control the merging behavior of:
+可以控制合并的表属性如下：
-* CONSTRAINTS - constraints such as primary and unique keys
-* GENERATED - computed columns
-* OPTIONS - connector options that describe connector and format properties
-* PARTITIONS - partition of the tables
-* WATERMARKS - watermark declarations
+* CONSTRAINTS - 主键和唯一键约束
+* GENERATED - 计算列
+* OPTIONS - 连接器信息、格式化方式等配置项
+* PARTITIONS - 表分区信息
+* WATERMARKS - watermark 定义
-with three different merging strategies:
+并且有三种不同的表属性合并策略：
-* INCLUDING - Includes the feature of the source table, fails on duplicate entries, e.g. if an option with the same key exists in both tables.
-* EXCLUDING - Does not include the given feature of the source table.
-* OVERWRITING - Includes the feature of the source table, overwrites duplicate entries of the source table with properties of the new table, e.g. if an option with the same key exists in both tables, the one from the current statement will be used.
+* INCLUDING - 新表包含源表（source table）所有的表属性，如果和源表的表属性重复则会直接失败，例如新表和源表存在相同 key 的属性。
+* EXCLUDING - 新表不包含源表指定的任何表属性。
+* OVERWRITING - 新表包含源表的表属性，但如果出现重复项，则会用新表的表属性覆盖源表中的重复表属性，例如，两个表中都存在相同 key 的属性，则会使用当前语句中定义的 key 的属性值。
-Additionally, you can use the `INCLUDING/EXCLUDING ALL` option to specify what should be the strategy if there was no specific strategy defined, i.e. if you use `EXCLUDING ALL INCLUDING WATERMARKS` only the watermarks will be included from the source table.
+并且你可以使用 `INCLUDING/EXCLUDING ALL` 这种声明方式来指定使用怎样的合并策略，例如使用 `EXCLUDING ALL INCLUDING WATERMARKS`，那么代表只有源表的 WATERMARKS 属性才会被包含进新表。
-Example:
+示例如下：
{% highlight sql %}
--- A source table stored in a filesystem
+
+-- 存储在文件系统的源表
CREATE TABLE Orders_in_file (
user BIGINT,
product STRING,
order_time_string STRING,
order_time AS to_timestamp(order_time)
-
+
Review comment:
> 这个无关的修改可以去掉
谢谢~，已修改。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on a change in pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on a change in pull request #12313:
URL: https://github.com/apache/flink/pull/12313#discussion_r431088645
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -208,14 +215,14 @@ CREATE TABLE Orders (
**注意：** 使用 `CREATE TABLE` 语句注册的表均可用作 table source 和 table sink。 在被 DML 语句引用前，我们无法决定其实际用于 source 抑或是 sink。
-**LIKE clause**
+**LIKE**
+
+`LIKE` 子句来源于两种 SQL 特性的变体/组合（Feature T171，“表定义中的LIKE语法” 和 Feature T173，“表定义中的LIKE语法扩展”）。LIKE 子句可以基于现有表的定义去创建新表，并且可以扩展或排除原始表中的某些部分。与 SQL 标准相反，LIKE 子句必须在 CREATE 语句中定义。这是因为 LIKE 子句可以应用于表定义的多个部分，而不仅仅是 schema 部分。
Review comment:
> 另外这里的实现细节我不是太清楚，但是从字面上看 “at the top-level of a CREATE statement" 这里翻译成”必须在 CREATE 语句中定义“，我比较好奇这里说的 ”top-level“ 是指什么意思呢？
这里的”top-level“我原本理解是用来形容create table的，类似于DDL对比与DML是”top-level“，所以我使用了“必须在 CREATE 语句中定义“这样的描述。
现在我有一些不同的理解：对比于create table，like字句是一个更上层的定义方式，这部分我之后再思考下。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
}, {
"hash" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144",
"triggerID" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"triggerType" : "PUSH"
}, {
"hash" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2312",
"triggerID" : "b67b757ed5193ab53f899e9501e4ce96551f8c40",
"triggerType" : "PUSH"
}, {
"hash" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "05c952fdab2c5cf05b70fa26bd7049a827d06149",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b67b757ed5193ab53f899e9501e4ce96551f8c40 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2312)
* 05c952fdab2c5cf05b70fa26bd7049a827d06149 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
klion26 commented on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633558758
@yangyichao-mango thanks for your contribution, could you please git rid of the "merge" commit? you can use "git rebase" instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] yangyichao-mango commented on a change in pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on a change in pull request #12313:
URL: https://github.com/apache/flink/pull/12313#discussion_r431134547
##########
File path: docs/dev/table/sql/create.zh.md
##########
@@ -249,59 +257,60 @@ CREATE TABLE Orders_with_watermark (
);
{% endhighlight %}
-The merging logic of table features can be controlled with `like options`.
+表属性的合并逻辑可以用 `like options` 来控制。
-You can control the merging behavior of:
+可以控制合并的表属性如下：
-* CONSTRAINTS - constraints such as primary and unique keys
-* GENERATED - computed columns
-* OPTIONS - connector options that describe connector and format properties
-* PARTITIONS - partition of the tables
-* WATERMARKS - watermark declarations
+* CONSTRAINTS - 主键和唯一键约束
+* GENERATED - 计算列
+* OPTIONS - 连接器和格式化的配置项
+* PARTITIONS - 表分区信息
+* WATERMARKS - watermark 定义
-with three different merging strategies:
+并且有三种不同的表属性合并策略：
-* INCLUDING - Includes the feature of the source table, fails on duplicate entries, e.g. if an option with the same key exists in both tables.
-* EXCLUDING - Does not include the given feature of the source table.
-* OVERWRITING - Includes the feature of the source table, overwrites duplicate entries of the source table with properties of the new table, e.g. if an option with the same key exists in both tables, the one from the current statement will be used.
+* INCLUDING - 新表包含源表（source table）所有的表属性，如果和源表的表属性重复则会直接失败，例如新表和源表存在相同 key 的属性。
+* EXCLUDING - 新表不包含源表指定的任何表属性。
+* OVERWRITING - 新表包含源表的表属性，但如果出现重复项，则会用新表的表属性覆盖源表中的重复表属性，例如，两个表中都存在相同 key 的属性，则会使用当前语句中定义的 key 的属性值。
-Additionally, you can use the `INCLUDING/EXCLUDING ALL` option to specify what should be the strategy if there was no specific strategy defined, i.e. if you use `EXCLUDING ALL INCLUDING WATERMARKS` only the watermarks will be included from the source table.
+此外，如果没有特别指定合并策略，也可以使用 `INCLUDING/EXCLUDING ALL` 这种声明方式来指定使用怎样的合并策略，例如使用 `EXCLUDING ALL INCLUDING WATERMARKS`，那么代表只有源表的 WATERMARKS 属性才会被包含进新表。
Review comment:
这里是指可以使用，因为根据代码实现和使用方式来看，只能使用”INCLUDING/EXCLUDING ALL“这类方式来指定合并策略
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12313: [FLINK-17005][docs] Translate the CREATE TABLE ... LIKE syntax documentation to Chinese
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12313:
URL: https://github.com/apache/flink/pull/12313#issuecomment-633389597
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c225fa8b2a774a8579501e136004a9d64db89244",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2108",
"triggerID" : "c225fa8b2a774a8579501e136004a9d64db89244",
"triggerType" : "PUSH"
}, {
"hash" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144",
"triggerID" : "07ab8aa279380cc6584c9602a1c344dfb2294074",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 07ab8aa279380cc6584c9602a1c344dfb2294074 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2144)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org