[GitHub] rob05c commented on a change in pull request #3286: Pattern-based consistent hashing feature for TR/TO/TP

[GitBox <gi...@apache.org>]

rob05c commented on a change in pull request #3286: Pattern-based consistent hashing feature for TR/TO/TP
URL: https://github.com/apache/trafficcontrol/pull/3286#discussion_r255667548
 
 

 ##########
 File path: docs/source/api/consistenthash.rst
 ##########
 @@ -0,0 +1,50 @@
+..
+..
+.. Licensed under the Apache License, Version 2.0 (the "License");
+.. you may not use this file except in compliance with the License.
+.. You may obtain a copy of the License at
+..
+..     http://www.apache.org/licenses/LICENSE-2.0
+..
+.. Unless required by applicable law or agreed to in writing, software
+.. distributed under the License is distributed on an "AS IS" BASIS,
+.. WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+.. See the License for the specific language governing permissions and
+.. limitations under the License.
+..
+
+.. _to-api-consistenthash:
+
+***************
+``consistenthash``
+***************
+Test pattern based consistent hashing for a Delivery Service using a regex and a request path
+
+``POST``
 
 Review comment:
   Yeah, the regex can contain special characters. It'd have to be encoded, which would be awkward and difficult to use.
   
   I'd vote keeping it a POST. It feels odd, but I think it's a pretty standard technique for APIs, for endpoints that require data with special characters or large amounts of data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services