[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6615: Add I2C slave mode for RP2040

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #6615:
URL: https://github.com/apache/incubator-nuttx/pull/6615#discussion_r922093456


##########
include/nuttx/i2c/i2c_slave.h:
##########
@@ -164,6 +208,8 @@ struct i2c_slaveops_s
         int buflen);
   int (*registercallback)(FAR struct i2c_slave_s *dev,
         int (*callback)(FAR void *arg), FAR void *arg);
+  int (*registercallback_len)(FAR struct i2c_slave_s *dev,
+        int (*callback_len)(FAR void *arg, size_t rx_len), FAR void *arg);

Review Comment:
   i2c_slave.h isn't used in many place in the current code base, so it's still good time to modify the prototype. BTW, since the upgrade path is very clear, it's very easy to update the old code to fix the new interface.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org