You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "David Phillips (JIRA)" <ji...@apache.org> on 2009/06/04 00:28:07 UTC
[jira] Created: (VYSPER-72) Support XEP0049-PrivateData
Support XEP0049-PrivateData
---------------------------
Key: VYSPER-72
URL: https://issues.apache.org/jira/browse/VYSPER-72
Project: VYSPER
Issue Type: New Feature
Reporter: David Phillips
Assignee: Bernd Fondermann
Priority: Minor
I would like to use JBuddy and Spark as clients, and both use the PrivateData IQ messages....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (VYSPER-72) Support XEP0049-PrivateData
Posted by "David Phillips (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Phillips updated VYSPER-72:
---------------------------------
Attachment: (was: xep0049.patch)
> Support XEP0049-PrivateData
> ---------------------------
>
> Key: VYSPER-72
> URL: https://issues.apache.org/jira/browse/VYSPER-72
> Project: VYSPER
> Issue Type: New Feature
> Reporter: David Phillips
> Assignee: Bernd Fondermann
> Priority: Minor
> Attachments: cleanups.patch
>
>
> I would like to use JBuddy and Spark as clients, and both use the PrivateData IQ messages....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[vysper] Re: [jira] Updated: (VYSPER-72) Support XEP0049-PrivateData
Posted by Bernd Fondermann <bf...@brainlounge.de>.
Hi David,
thanks for your contribution.
I'll have a look at it next week, since I'm practically offline currently.
Thanks,
Bernd
David Phillips (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/VYSPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> David Phillips updated VYSPER-72:
> ---------------------------------
>
> Attachment: xep0049.patch
>
> Here is a patch that implements XEP0049
>
>> Support XEP0049-PrivateData
>> ---------------------------
>>
>> Key: VYSPER-72
>> URL: https://issues.apache.org/jira/browse/VYSPER-72
>> Project: VYSPER
>> Issue Type: New Feature
>> Reporter: David Phillips
>> Assignee: Bernd Fondermann
>> Priority: Minor
>> Attachments: xep0049.patch
>>
>>
>> I would like to use JBuddy and Spark as clients, and both use the PrivateData IQ messages....
>
[jira] Updated: (VYSPER-72) Support XEP0049-PrivateData
Posted by "David Phillips (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Phillips updated VYSPER-72:
---------------------------------
Attachment: xep0049.patch
Here is a patch that implements XEP0049
> Support XEP0049-PrivateData
> ---------------------------
>
> Key: VYSPER-72
> URL: https://issues.apache.org/jira/browse/VYSPER-72
> Project: VYSPER
> Issue Type: New Feature
> Reporter: David Phillips
> Assignee: Bernd Fondermann
> Priority: Minor
> Attachments: xep0049.patch
>
>
> I would like to use JBuddy and Spark as clients, and both use the PrivateData IQ messages....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VYSPER-72) Support XEP0049-PrivateData
Posted by "Bernd Fondermann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717716#action_12717716 ]
Bernd Fondermann commented on VYSPER-72:
----------------------------------------
RE xep0049.patch: I can't apply the patch yet, but we will get there. This is a great improvement for Vysper. Please keep contributing!
At first: Please adopt to the project's code formatting. Please use 4 space indentions (and no tabs).
Avoid @Override when implementing interfaces, as we are still supporting Java 5, where this is a compile error.
StanzaErrorCondition: bad-format is not a stanza error condition, it's a stream error. Please refer to RFC3920 for more details.
If you need a stanza error, chose a different condition.
If you need bad-format, create a stream error, but this would terminate the session, so I guess it is not an option.
What does the XEP say?
Otherwise, the patch looks pretty good (pending me reading the full private data XEP)!
> Support XEP0049-PrivateData
> ---------------------------
>
> Key: VYSPER-72
> URL: https://issues.apache.org/jira/browse/VYSPER-72
> Project: VYSPER
> Issue Type: New Feature
> Reporter: David Phillips
> Assignee: Bernd Fondermann
> Priority: Minor
> Attachments: cleanups.patch, xep0049.patch
>
>
> I would like to use JBuddy and Spark as clients, and both use the PrivateData IQ messages....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (VYSPER-72) Support XEP0049-PrivateData
Posted by "David Phillips (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Phillips updated VYSPER-72:
---------------------------------
Attachment: xep00049-v2.patch
Here is the updated patch with your suggestions included...
> Support XEP0049-PrivateData
> ---------------------------
>
> Key: VYSPER-72
> URL: https://issues.apache.org/jira/browse/VYSPER-72
> Project: VYSPER
> Issue Type: New Feature
> Reporter: David Phillips
> Assignee: Bernd Fondermann
> Priority: Minor
> Attachments: cleanups.patch, xep00049-v2.patch
>
>
> I would like to use JBuddy and Spark as clients, and both use the PrivateData IQ messages....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VYSPER-72) Support XEP0049-PrivateData
Posted by "Bernd Fondermann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716218#action_12716218 ]
Bernd Fondermann commented on VYSPER-72:
----------------------------------------
The patch seems to lack all the files/classes you added, only changed code is included, or am I missing something? Maybe svn add'ing them helps to get them included.
If you have the time, please split out bugfixes and general improvements into their own patches/jiras. This would help getting the patches applied.
Thanks!
Bernd
> Support XEP0049-PrivateData
> ---------------------------
>
> Key: VYSPER-72
> URL: https://issues.apache.org/jira/browse/VYSPER-72
> Project: VYSPER
> Issue Type: New Feature
> Reporter: David Phillips
> Assignee: Bernd Fondermann
> Priority: Minor
> Attachments: xep0049.patch
>
>
> I would like to use JBuddy and Spark as clients, and both use the PrivateData IQ messages....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VYSPER-72) Support XEP0049-PrivateData
Posted by "Bernd Fondermann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717708#action_12717708 ]
Bernd Fondermann commented on VYSPER-72:
----------------------------------------
RE cleanup.patch: I didn't incorporate all the changes in verbatim, and I'm discussing below, why.
TCPEndpoint: left out SocketAcceptor init changes. I currently don't see a good reason to do so.
XmppIoHandlerAdapter: tried to be more clear in the message text. Agreed?
XMLElementVerifier: patch could not be applied. is this based on the latest trunk?
apart from that technical problem, did you run the unit tests against this change?
EntityTimeXEP0090IQHandler: What's the point in changing this to GMT? UTC is much more illustrating and it works for me.
I'm happy to continue discussing this changes, if valuable.
> Support XEP0049-PrivateData
> ---------------------------
>
> Key: VYSPER-72
> URL: https://issues.apache.org/jira/browse/VYSPER-72
> Project: VYSPER
> Issue Type: New Feature
> Reporter: David Phillips
> Assignee: Bernd Fondermann
> Priority: Minor
> Attachments: cleanups.patch, xep0049.patch
>
>
> I would like to use JBuddy and Spark as clients, and both use the PrivateData IQ messages....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (VYSPER-72) Support XEP0049-PrivateData
Posted by "Bernd Fondermann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bernd Fondermann updated VYSPER-72:
-----------------------------------
Component/s: extension
> Support XEP0049-PrivateData
> ---------------------------
>
> Key: VYSPER-72
> URL: https://issues.apache.org/jira/browse/VYSPER-72
> Project: VYSPER
> Issue Type: New Feature
> Components: extension
> Reporter: David Phillips
> Assignee: Bernd Fondermann
> Priority: Minor
> Attachments: cleanups.patch, xep00049-v2.patch
>
>
> I would like to use JBuddy and Spark as clients, and both use the PrivateData IQ messages....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VYSPER-72) Support XEP0049-PrivateData
Posted by "Bernd Fondermann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717729#action_12717729 ]
Bernd Fondermann commented on VYSPER-72:
----------------------------------------
RE bad-format:
the xep indeed says bad-format. this can be created using
ServerErrorResponses.getInstance().getStreamError()
> Support XEP0049-PrivateData
> ---------------------------
>
> Key: VYSPER-72
> URL: https://issues.apache.org/jira/browse/VYSPER-72
> Project: VYSPER
> Issue Type: New Feature
> Reporter: David Phillips
> Assignee: Bernd Fondermann
> Priority: Minor
> Attachments: cleanups.patch, xep0049.patch
>
>
> I would like to use JBuddy and Spark as clients, and both use the PrivateData IQ messages....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (VYSPER-72) Support XEP0049-PrivateData
Posted by "David Phillips (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Phillips updated VYSPER-72:
---------------------------------
Attachment: (was: xep0049.patch)
> Support XEP0049-PrivateData
> ---------------------------
>
> Key: VYSPER-72
> URL: https://issues.apache.org/jira/browse/VYSPER-72
> Project: VYSPER
> Issue Type: New Feature
> Reporter: David Phillips
> Assignee: Bernd Fondermann
> Priority: Minor
> Attachments: cleanups.patch, xep0049.patch
>
>
> I would like to use JBuddy and Spark as clients, and both use the PrivateData IQ messages....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (VYSPER-72) Support XEP0049-PrivateData
Posted by "Bernd Fondermann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bernd Fondermann resolved VYSPER-72.
------------------------------------
Resolution: Fixed
> Support XEP0049-PrivateData
> ---------------------------
>
> Key: VYSPER-72
> URL: https://issues.apache.org/jira/browse/VYSPER-72
> Project: VYSPER
> Issue Type: New Feature
> Components: extension
> Reporter: David Phillips
> Assignee: Bernd Fondermann
> Priority: Minor
> Attachments: cleanups.patch, xep00049-v2.patch
>
>
> I would like to use JBuddy and Spark as clients, and both use the PrivateData IQ messages....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VYSPER-72) Support XEP0049-PrivateData
Posted by "Bernd Fondermann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717735#action_12717735 ]
Bernd Fondermann commented on VYSPER-72:
----------------------------------------
RE setting jabber:iq:private data in a reserved namespace
Returning an error here is OPTIONAL, and I would refrain from doing so.
Accepting those data is more liberal (which is good) and we cannot provide an exhausting list of namespaces.
It makes the impl more simple. Example 5 in the XEP only serves as a warning for client implementors, as far as I understand it.
> Support XEP0049-PrivateData
> ---------------------------
>
> Key: VYSPER-72
> URL: https://issues.apache.org/jira/browse/VYSPER-72
> Project: VYSPER
> Issue Type: New Feature
> Reporter: David Phillips
> Assignee: Bernd Fondermann
> Priority: Minor
> Attachments: cleanups.patch, xep0049.patch
>
>
> I would like to use JBuddy and Spark as clients, and both use the PrivateData IQ messages....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (VYSPER-72) Support XEP0049-PrivateData
Posted by "David Phillips (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Phillips updated VYSPER-72:
---------------------------------
Attachment: cleanups.patch
xep0049.patch
Sorry, about that!
Ive split the previous patch into:
xep0049.patch for the PrivateData (XEP0049) changes
cleanups.patch for some misc changes that help me intergrate a new filter into the chain
> Support XEP0049-PrivateData
> ---------------------------
>
> Key: VYSPER-72
> URL: https://issues.apache.org/jira/browse/VYSPER-72
> Project: VYSPER
> Issue Type: New Feature
> Reporter: David Phillips
> Assignee: Bernd Fondermann
> Priority: Minor
> Attachments: cleanups.patch, xep0049.patch
>
>
> I would like to use JBuddy and Spark as clients, and both use the PrivateData IQ messages....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (VYSPER-72) Support XEP0049-PrivateData
Posted by "David Phillips (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VYSPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717861#action_12717861 ]
David Phillips commented on VYSPER-72:
--------------------------------------
Ive updated the attached patch... hopefully its all OKdokie
TCPEndpoint: left out SocketAcceptor init changes. I currently don't see a good reason to do so.
--Fine, please just ignore the change :)
EntityTimeXEP0090IQHandler: What's the point in changing this to GMT? UTC is much more illustrating and it works for me.
-- Interesting... Java6_14 does not use UTC, but Etc/UTC. Ive added a link to my jre/lib/tz from Etc/UTC to ../UTC
@Override
-- Sorry, didnt realize that
StanzaErrorCondition -> StreamErrorCondition
-- Fixed
> Support XEP0049-PrivateData
> ---------------------------
>
> Key: VYSPER-72
> URL: https://issues.apache.org/jira/browse/VYSPER-72
> Project: VYSPER
> Issue Type: New Feature
> Reporter: David Phillips
> Assignee: Bernd Fondermann
> Priority: Minor
> Attachments: cleanups.patch, xep00049-v2.patch
>
>
> I would like to use JBuddy and Spark as clients, and both use the PrivateData IQ messages....
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.