[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31603: [SPARK-34029][SQL][TESTS] Add OrcEncryptionSuite and FakeKeyProvider

[GitBox <gi...@apache.org>]

dongjoon-hyun edited a comment on pull request #31603:
URL: https://github.com/apache/spark/pull/31603#issuecomment-783066869


   Hi, @HyukjinKwon . This is a security feature and Apache ORC [CryptoUtils](https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/CryptoUtils.java#L158) creates the key provider from its [Singleton Hadoop Shims Factory](https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/HadoopShimsFactory.java#L50). If the other non-secured ORC code creates this without a proper configuration first, it will get [NullKeyProvider](https://github.com/apache/orc/blob/b05350a384dd92e2f8579f9997d1d9b36b7fcb68/java/shims/src/java/org/apache/orc/impl/HadoopShimsPre2_7.java#L225) and affects all the subsequent test cases.
   > Do we know the reason why it needs to run the test in a separate forked JVM to pass?
   
   Tag `DedicatedJVM` sounds better to me, too. I'll make a follow-up.
   > DedicatedJVM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org