You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Francois Fernandes (JIRA)" <ji...@apache.org> on 2009/02/13 16:31:59 UTC
[jira] Created: (WICKET-2103) SignInPanel.onSignInSucceeded call
the correct method on IPageFactory
SignInPanel.onSignInSucceeded call the correct method on IPageFactory
---------------------------------------------------------------------
Key: WICKET-2103
URL: https://issues.apache.org/jira/browse/WICKET-2103
Project: Wicket
Issue Type: Bug
Components: wicket-auth-roles
Reporter: Francois Fernandes
The onSignInSucceeded method is calling newPage(Class, PageParameters) with PageParameters = null. Instead of this, the call should be changed to use the newPage(Class) method instead.
setResponsePage(getApplication().getSessionSettings().getPageFactory().newPage(getApplication().getHomePage(), (PageParameters)null));
should be changed to
setResponsePage(getApplication().getSessionSettings().getPageFactory().newPage(getApplication().getHomePage()));
This is releated to WICKET-2092.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2103) SignInPanel.onSignInSucceeded call
the correct method on IPageFactory
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-2103.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.4-RC3
Assignee: Juergen Donnerstag
thanks
> SignInPanel.onSignInSucceeded call the correct method on IPageFactory
> ---------------------------------------------------------------------
>
> Key: WICKET-2103
> URL: https://issues.apache.org/jira/browse/WICKET-2103
> Project: Wicket
> Issue Type: Bug
> Components: wicket-auth-roles
> Reporter: Francois Fernandes
> Assignee: Juergen Donnerstag
> Fix For: 1.4-RC3
>
>
> The onSignInSucceeded method is calling newPage(Class, PageParameters) with PageParameters = null. Instead of this, the call should be changed to use the newPage(Class) method instead.
> setResponsePage(getApplication().getSessionSettings().getPageFactory().newPage(getApplication().getHomePage(), (PageParameters)null));
> should be changed to
> setResponsePage(getApplication().getSessionSettings().getPageFactory().newPage(getApplication().getHomePage()));
> This is releated to WICKET-2092.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2103) SignInPanel.onSignInSucceeded call
the correct method on IPageFactory
Posted by "Francois Fernandes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673855#action_12673855 ]
Francois Fernandes commented on WICKET-2103:
--------------------------------------------
wow, that was fast! Thank you for fixing this! I'm really looking forward for the final 1.4 Release!
> SignInPanel.onSignInSucceeded call the correct method on IPageFactory
> ---------------------------------------------------------------------
>
> Key: WICKET-2103
> URL: https://issues.apache.org/jira/browse/WICKET-2103
> Project: Wicket
> Issue Type: Bug
> Components: wicket-auth-roles
> Reporter: Francois Fernandes
> Assignee: Juergen Donnerstag
> Fix For: 1.4-RC3
>
>
> The onSignInSucceeded method is calling newPage(Class, PageParameters) with PageParameters = null. Instead of this, the call should be changed to use the newPage(Class) method instead.
> setResponsePage(getApplication().getSessionSettings().getPageFactory().newPage(getApplication().getHomePage(), (PageParameters)null));
> should be changed to
> setResponsePage(getApplication().getSessionSettings().getPageFactory().newPage(getApplication().getHomePage()));
> This is releated to WICKET-2092.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.