You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@tomcat.apache.org by Jeffrey Barnett <je...@yale.edu> on 2005/03/28 18:41:38 UTC
Re: Admin application creates duplicate "secure" attribute in server.xml
Mike, unfortunately I'm only gotten better at restoring server.xml after
it has been corrupted. You are the first person from the tomcat-user
list to even confirm that the problem exits on other sites.. One
consultant I consulted said that they had never heard of the problem,
but that we were also the first site he had worked with that actually
used the admin function actively, By the way, just for the record, not
only the secure attribute, but also the protocol attribute is
duplicated, right? And only on the SSL connector.
Mike Dippold wrote:
>I just wanted to check to see if you have figured anything out with the tomcat admin ssl duplicate problem. I have tried it on 5.0.28 and also 5.5.7 and every time I change a datasource or anything else, it corrupts the xml.
>
>Thanks,
>Mike Dippold
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-user-help@jakarta.apache.org
Re: Admin application creates duplicate "secure" attribute in server.xml
Posted by Peter Rossbach <pr...@objektpark.de>.
Hello Jeffrey,
I have no time to made a storeconfig backport to the Tomcat 5.0 tree.
Sorry, the 5.0.x is in some places very
unfriendly. When you want a local workaround look inside
StandardServer#storeConnector.
The probleme is the storeAttributes method calls for real Connector and
also for ProtocolHandler
L_1107
---
writer.print("<Connector");
storeAttributes(writer, connector);
if (connector instanceof CoyoteConnector) {
ProtocolHandler protocolHandler =
((CoyoteConnector)connector).getProtocolHandler();
storeAttributes(writer, protocolHandler);
}
writer.println(">");
-----
What you need is a frontup merge, defaulthandling and renaming of some
attributes (protocol at ProtocolHandler means sslProtocol at Connector
Element) ?Arggh, ... very bad, but the 5.5.x Connector is complete
rewritten and has a nice storeconfig module to handle some bad cases :-)
Implement a better Connector attribute saving algo, send me the code for
testing
Why you want to wait, Tomat 5.5.9 is really stabler as 5.0.28.
Peter
Jeffrey Barnett schrieb:
> Peter,
> Many thanks for finding and fixing the bug, however we are currently
> running 5.0.28, and not likely to upgrade until summer. Can you
> describe enough about the problem that I could track it down and
> create a local fix / work around until then?
>
> Peter Rossbach wrote:
>
>> Yes the wrong saving SSL Connector is a bug and I fix it for Tomcat
>> 5.5.x.
>>
>> The old StandardServer saving code was strange. The new StoreConfig
>> module has
>> a flexible customizable API to store server.xml and context.xml.
>>
>> You can activate the new saving module with
>>
>> <Server ...>
>> <Listener
>> className="org.apache.catalina.storeconfig.StoreConfigLifecycleListener"/>
>>
>>
>> ....
>> </Server>
>>
>> This listener register a new MBean with more options to save the
>> tomcat configurations.
>>
>> Give 5.5.9 a try ... :-)
>>
>> Peter
>>
>> Jeffrey Barnett schrieb:
>>
>>> Mike, unfortunately I'm only gotten better at restoring server.xml
>>> after it has been corrupted. You are the first person from the
>>> tomcat-user list to even confirm that the problem exits on other
>>> sites.. One consultant I consulted said that they had never heard of
>>> the problem, but that we were also the first site he had worked with
>>> that actually used the admin function actively, By the way, just
>>> for the record, not only the secure attribute, but also the protocol
>>> attribute is duplicated, right? And only on the SSL connector.
>>>
>>> Mike Dippold wrote:
>>>
>>>> I just wanted to check to see if you have figured anything out with
>>>> the tomcat admin ssl duplicate problem. I have tried it on 5.0.28
>>>> and also 5.5.7 and every time I change a datasource or anything
>>>> else, it corrupts the xml.
>>>>
>>>> Thanks,
>>>> Mike Dippold
>>>
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: tomcat-user-unsubscribe@jakarta.apache.org
>>> For additional commands, e-mail: tomcat-user-help@jakarta.apache.org
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tomcat-user-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: tomcat-user-help@jakarta.apache.org
>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-user-help@jakarta.apache.org
Re: Admin application creates duplicate "secure" attribute in server.xml
Posted by Jeffrey Barnett <je...@yale.edu>.
Peter,
Many thanks for finding and fixing the bug, however we are currently
running 5.0.28, and not likely to upgrade until summer. Can you
describe enough about the problem that I could track it down and create
a local fix / work around until then?
Peter Rossbach wrote:
> Yes the wrong saving SSL Connector is a bug and I fix it for Tomcat
> 5.5.x.
>
> The old StandardServer saving code was strange. The new StoreConfig
> module has
> a flexible customizable API to store server.xml and context.xml.
>
> You can activate the new saving module with
>
> <Server ...>
> <Listener
> className="org.apache.catalina.storeconfig.StoreConfigLifecycleListener"/>
>
>
> ....
> </Server>
>
> This listener register a new MBean with more options to save the
> tomcat configurations.
>
> Give 5.5.9 a try ... :-)
>
> Peter
>
> Jeffrey Barnett schrieb:
>
>> Mike, unfortunately I'm only gotten better at restoring server.xml
>> after it has been corrupted. You are the first person from the
>> tomcat-user list to even confirm that the problem exits on other
>> sites.. One consultant I consulted said that they had never heard of
>> the problem, but that we were also the first site he had worked with
>> that actually used the admin function actively, By the way, just for
>> the record, not only the secure attribute, but also the protocol
>> attribute is duplicated, right? And only on the SSL connector.
>>
>> Mike Dippold wrote:
>>
>>> I just wanted to check to see if you have figured anything out with
>>> the tomcat admin ssl duplicate problem. I have tried it on 5.0.28
>>> and also 5.5.7 and every time I change a datasource or anything
>>> else, it corrupts the xml.
>>>
>>> Thanks,
>>> Mike Dippold
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tomcat-user-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: tomcat-user-help@jakarta.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-user-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-user-help@jakarta.apache.org
Re: Admin application creates duplicate "secure" attribute in server.xml
Posted by Peter Rossbach <pr...@objektpark.de>.
Yes the wrong saving SSL Connector is a bug and I fix it for Tomcat 5.5.x.
The old StandardServer saving code was strange. The new StoreConfig
module has
a flexible customizable API to store server.xml and context.xml.
You can activate the new saving module with
<Server ...>
<Listener
className="org.apache.catalina.storeconfig.StoreConfigLifecycleListener"/>
....
</Server>
This listener register a new MBean with more options to save the tomcat
configurations.
Give 5.5.9 a try ... :-)
Peter
Jeffrey Barnett schrieb:
> Mike, unfortunately I'm only gotten better at restoring server.xml
> after it has been corrupted. You are the first person from the
> tomcat-user list to even confirm that the problem exits on other
> sites.. One consultant I consulted said that they had never heard of
> the problem, but that we were also the first site he had worked with
> that actually used the admin function actively, By the way, just for
> the record, not only the secure attribute, but also the protocol
> attribute is duplicated, right? And only on the SSL connector.
>
> Mike Dippold wrote:
>
>> I just wanted to check to see if you have figured anything out with
>> the tomcat admin ssl duplicate problem. I have tried it on 5.0.28
>> and also 5.5.7 and every time I change a datasource or anything else,
>> it corrupts the xml.
>>
>> Thanks,
>> Mike Dippold
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-user-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-user-help@jakarta.apache.org