You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "jpountz (via GitHub)" <gi...@apache.org> on 2024/04/30 14:07:41 UTC
[PR] Make segment/field attribute updates thread-safe. [lucene]
jpountz opened a new pull request, #13331:
URL: https://github.com/apache/lucene/pull/13331
Because of concurrent merging (#13124), multiple threads may be updating (different) attributes concurrently, so we need to make reads and writes to attributes thread-safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Make segment/field attribute updates thread-safe. [lucene]
Posted by "benwtrent (via GitHub)" <gi...@apache.org>.
benwtrent commented on code in PR #13331:
URL: https://github.com/apache/lucene/pull/13331#discussion_r1584982931
##########
lucene/core/src/java/org/apache/lucene/index/FieldInfo.java:
##########
@@ -628,12 +630,17 @@ public String getAttribute(String key) {
* If the value of the attributes for a same field is changed between the documents, the behaviour
* after merge is undefined.
*/
- public String putAttribute(String key, String value) {
- return attributes.put(key, value);
+ public synchronized String putAttribute(String key, String value) {
+ HashMap<String, String> newMap = new HashMap<>(attributes);
+ String oldValue = newMap.put(key, value);
+ // This needs to be thread-safe as multiple threads may be updating (different) attributes
+ // concurrently due to concurrent merging.
+ attributes = Collections.unmodifiableMap(newMap);
Review Comment:
I don't understand why we are copying the map, why not use a `ConcurrentHashMap`?
Is this because we don't want this changing at all after something calls `attributes()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Make segment/field attribute updates thread-safe. [lucene]
Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz commented on code in PR #13331:
URL: https://github.com/apache/lucene/pull/13331#discussion_r1584993348
##########
lucene/core/src/java/org/apache/lucene/index/FieldInfo.java:
##########
@@ -628,12 +630,17 @@ public String getAttribute(String key) {
* If the value of the attributes for a same field is changed between the documents, the behaviour
* after merge is undefined.
*/
- public String putAttribute(String key, String value) {
- return attributes.put(key, value);
+ public synchronized String putAttribute(String key, String value) {
+ HashMap<String, String> newMap = new HashMap<>(attributes);
+ String oldValue = newMap.put(key, value);
+ // This needs to be thread-safe as multiple threads may be updating (different) attributes
+ // concurrently due to concurrent merging.
+ attributes = Collections.unmodifiableMap(newMap);
Review Comment:
Indeed. Since SegmentInfo's attributes were already using this approach, I thought it made sense to follow the same approach instead of doing something different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Make segment/field attribute updates thread-safe. [lucene]
Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz merged PR #13331:
URL: https://github.com/apache/lucene/pull/13331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org