You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/10 19:35:24 UTC

[GitHub] [arrow] Dandandan commented on a change in pull request #9116: ARROW-11156: [Rust][DataFusion] Create hashes vectorized in hash join

Dandandan commented on a change in pull request #9116:
URL: https://github.com/apache/arrow/pull/9116#discussion_r554612380



##########
File path: rust/datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -329,6 +329,76 @@ fn group_aggregate_batch(
     Ok(accumulators)
 }
 
+/// Create a key `Vec<u8>` that is used as key for the hashmap
+fn create_key(group_by_keys: &[ArrayRef], row: usize, vec: &mut Vec<u8>) -> Result<()> {

Review comment:
       This moved to `hash_aggregate`. It can move once hash aggregate does stops using `Vec<u8>` as a key




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org