You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/05/21 02:18:05 UTC
Review Request 34513: Ranger HDFS/HBase Plugin Upgrade Pack For
HDP-2.2 To HDP-2.3
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34513/
-----------------------------------------------------------
Review request for Ambari and Jonathan Hurley.
Bugs: AMBARI-11289
https://issues.apache.org/jira/browse/AMBARI-11289
Repository: ambari
Description
-------
* Added configuration changes for ranger plugins
* Added masked attribute for sensitive config changes being written to task stdout.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c5f33c4
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 99d6058
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7505a07
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java c2ea948
Diff: https://reviews.apache.org/r/34513/diff/
Testing
-------
Pending
Thanks,
Nate Cole
Re: Review Request 34513: Ranger HDFS/HBase Plugin Upgrade Pack For
HDP-2.2 To HDP-2.3
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34513/#review84712
-----------------------------------------------------------
I just noticed something - in a lot of the <transfer> elements for "copy", there's no default value specified. This probably because there's an existing stack value in HDP 2.2 ... but what if there isn't? We should probably have defaults listed for these
- Jonathan Hurley
On May 21, 2015, 11:12 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34513/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 11:12 a.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-11289
> https://issues.apache.org/jira/browse/AMBARI-11289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added configuration changes for ranger plugins
> * Added masked attribute for sensitive config changes being written to task stdout.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c5f33c4
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 99d6058
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7505a07
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java c2ea948
>
> Diff: https://reviews.apache.org/r/34513/diff/
>
>
> Testing
> -------
>
> Tests run: 3001, Failures: 0, Errors: 0, Skipped: 21
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:51.152s
> [INFO] Finished at: Wed May 20 20:48:28 EDT 2015
> [INFO] Final Memory: 30M/1338M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 34513: Ranger HDFS/HBase Plugin Upgrade Pack For
HDP-2.2 To HDP-2.3
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On May 21, 2015, 11:58 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml, line 480
> > <https://reviews.apache.org/r/34513/diff/2/?file=966474#file966474line480>
> >
> > I was following this pattern for Hive when I realized something. Are these keys renames? If so, shouldn't we just use the "move" action to rename it in the new config? That would save us from having to do the copy/delete
>
> Nate Cole wrote:
> They're different config types so they can't be moves. The ranger team didn't indicate that we should be removing the old values.
I disagree on this; we should be removing them as well to prevent confusion with old types. But you're right in another aspect; a move in between config types would change 2 config types in 1 configure task and that's bad mojo. So I'll drop this.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34513/#review84714
-----------------------------------------------------------
On May 21, 2015, 11:12 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34513/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 11:12 a.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-11289
> https://issues.apache.org/jira/browse/AMBARI-11289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added configuration changes for ranger plugins
> * Added masked attribute for sensitive config changes being written to task stdout.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c5f33c4
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 99d6058
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7505a07
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java c2ea948
>
> Diff: https://reviews.apache.org/r/34513/diff/
>
>
> Testing
> -------
>
> Tests run: 3001, Failures: 0, Errors: 0, Skipped: 21
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:51.152s
> [INFO] Finished at: Wed May 20 20:48:28 EDT 2015
> [INFO] Final Memory: 30M/1338M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 34513: Ranger HDFS/HBase Plugin Upgrade Pack For
HDP-2.2 To HDP-2.3
Posted by Nate Cole <nc...@hortonworks.com>.
> On May 21, 2015, 11:58 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml, line 480
> > <https://reviews.apache.org/r/34513/diff/2/?file=966474#file966474line480>
> >
> > I was following this pattern for Hive when I realized something. Are these keys renames? If so, shouldn't we just use the "move" action to rename it in the new config? That would save us from having to do the copy/delete
They're different config types so they can't be moves. The ranger team didn't indicate that we should be removing the old values.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34513/#review84714
-----------------------------------------------------------
On May 21, 2015, 11:12 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34513/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 11:12 a.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-11289
> https://issues.apache.org/jira/browse/AMBARI-11289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added configuration changes for ranger plugins
> * Added masked attribute for sensitive config changes being written to task stdout.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c5f33c4
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 99d6058
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7505a07
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java c2ea948
>
> Diff: https://reviews.apache.org/r/34513/diff/
>
>
> Testing
> -------
>
> Tests run: 3001, Failures: 0, Errors: 0, Skipped: 21
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:51.152s
> [INFO] Finished at: Wed May 20 20:48:28 EDT 2015
> [INFO] Final Memory: 30M/1338M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 34513: Ranger HDFS/HBase Plugin Upgrade Pack For
HDP-2.2 To HDP-2.3
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34513/#review84714
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml
<https://reviews.apache.org/r/34513/#comment136051>
I was following this pattern for Hive when I realized something. Are these keys renames? If so, shouldn't we just use the "move" action to rename it in the new config? That would save us from having to do the copy/delete
- Jonathan Hurley
On May 21, 2015, 11:12 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34513/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 11:12 a.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-11289
> https://issues.apache.org/jira/browse/AMBARI-11289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added configuration changes for ranger plugins
> * Added masked attribute for sensitive config changes being written to task stdout.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c5f33c4
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 99d6058
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7505a07
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java c2ea948
>
> Diff: https://reviews.apache.org/r/34513/diff/
>
>
> Testing
> -------
>
> Tests run: 3001, Failures: 0, Errors: 0, Skipped: 21
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:51.152s
> [INFO] Finished at: Wed May 20 20:48:28 EDT 2015
> [INFO] Final Memory: 30M/1338M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 34513: Ranger HDFS/HBase Plugin Upgrade Pack For
HDP-2.2 To HDP-2.3
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34513/#review84735
-----------------------------------------------------------
Ship it!
I still think that we should delete the renamed properties...
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml
<https://reviews.apache.org/r/34513/#comment136074>
TRUE or true?
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml
<https://reviews.apache.org/r/34513/#comment136075>
true or TRUE?
- Jonathan Hurley
On May 21, 2015, 12:48 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34513/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 12:48 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-11289
> https://issues.apache.org/jira/browse/AMBARI-11289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added configuration changes for ranger plugins
> * Added masked attribute for sensitive config changes being written to task stdout.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c5f33c4
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 99d6058
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7505a07
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java c2ea948
>
> Diff: https://reviews.apache.org/r/34513/diff/
>
>
> Testing
> -------
>
> Tests run: 3001, Failures: 0, Errors: 0, Skipped: 21
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:51.152s
> [INFO] Finished at: Wed May 20 20:48:28 EDT 2015
> [INFO] Final Memory: 30M/1338M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 34513: Ranger HDFS/HBase Plugin Upgrade Pack For
HDP-2.2 To HDP-2.3
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34513/
-----------------------------------------------------------
(Updated May 21, 2015, 12:48 p.m.)
Review request for Ambari and Jonathan Hurley.
Changes
-------
Added default values for copy elements
Bugs: AMBARI-11289
https://issues.apache.org/jira/browse/AMBARI-11289
Repository: ambari
Description
-------
* Added configuration changes for ranger plugins
* Added masked attribute for sensitive config changes being written to task stdout.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c5f33c4
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 99d6058
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7505a07
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java c2ea948
Diff: https://reviews.apache.org/r/34513/diff/
Testing
-------
Tests run: 3001, Failures: 0, Errors: 0, Skipped: 21
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:51.152s
[INFO] Finished at: Wed May 20 20:48:28 EDT 2015
[INFO] Final Memory: 30M/1338M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 34513: Ranger HDFS/HBase Plugin Upgrade Pack For
HDP-2.2 To HDP-2.3
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34513/#review84713
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml
<https://reviews.apache.org/r/34513/#comment136050>
Here's an example ... I think there is a known default for this element.
- Jonathan Hurley
On May 21, 2015, 11:12 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34513/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 11:12 a.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-11289
> https://issues.apache.org/jira/browse/AMBARI-11289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added configuration changes for ranger plugins
> * Added masked attribute for sensitive config changes being written to task stdout.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c5f33c4
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 99d6058
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7505a07
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java c2ea948
>
> Diff: https://reviews.apache.org/r/34513/diff/
>
>
> Testing
> -------
>
> Tests run: 3001, Failures: 0, Errors: 0, Skipped: 21
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:51.152s
> [INFO] Finished at: Wed May 20 20:48:28 EDT 2015
> [INFO] Final Memory: 30M/1338M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 34513: Ranger HDFS/HBase Plugin Upgrade Pack For
HDP-2.2 To HDP-2.3
Posted by Nate Cole <nc...@hortonworks.com>.
> On May 21, 2015, 11:30 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java, line 512
> > <https://reviews.apache.org/r/34513/diff/2/?file=966472#file966472line512>
> >
> > Maybe a fixed value? You might be giving a clue here if you use the exact length.
The exact length is the only thing people could use to know if the value was set.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34513/#review84710
-----------------------------------------------------------
On May 21, 2015, 11:12 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34513/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 11:12 a.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-11289
> https://issues.apache.org/jira/browse/AMBARI-11289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added configuration changes for ranger plugins
> * Added masked attribute for sensitive config changes being written to task stdout.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c5f33c4
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 99d6058
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7505a07
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java c2ea948
>
> Diff: https://reviews.apache.org/r/34513/diff/
>
>
> Testing
> -------
>
> Tests run: 3001, Failures: 0, Errors: 0, Skipped: 21
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:51.152s
> [INFO] Finished at: Wed May 20 20:48:28 EDT 2015
> [INFO] Final Memory: 30M/1338M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 34513: Ranger HDFS/HBase Plugin Upgrade Pack For
HDP-2.2 To HDP-2.3
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34513/#review84710
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
<https://reviews.apache.org/r/34513/#comment136049>
Maybe a fixed value? You might be giving a clue here if you use the exact length.
- Jonathan Hurley
On May 21, 2015, 11:12 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34513/
> -----------------------------------------------------------
>
> (Updated May 21, 2015, 11:12 a.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-11289
> https://issues.apache.org/jira/browse/AMBARI-11289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added configuration changes for ranger plugins
> * Added masked attribute for sensitive config changes being written to task stdout.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c5f33c4
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 99d6058
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7505a07
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java c2ea948
>
> Diff: https://reviews.apache.org/r/34513/diff/
>
>
> Testing
> -------
>
> Tests run: 3001, Failures: 0, Errors: 0, Skipped: 21
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:51.152s
> [INFO] Finished at: Wed May 20 20:48:28 EDT 2015
> [INFO] Final Memory: 30M/1338M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 34513: Ranger HDFS/HBase Plugin Upgrade Pack For
HDP-2.2 To HDP-2.3
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34513/
-----------------------------------------------------------
(Updated May 21, 2015, 11:12 a.m.)
Review request for Ambari and Jonathan Hurley.
Changes
-------
Finalized config changes
Bugs: AMBARI-11289
https://issues.apache.org/jira/browse/AMBARI-11289
Repository: ambari
Description
-------
* Added configuration changes for ranger plugins
* Added masked attribute for sensitive config changes being written to task stdout.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c5f33c4
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 99d6058
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7505a07
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java c2ea948
Diff: https://reviews.apache.org/r/34513/diff/
Testing
-------
Tests run: 3001, Failures: 0, Errors: 0, Skipped: 21
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:51.152s
[INFO] Finished at: Wed May 20 20:48:28 EDT 2015
[INFO] Final Memory: 30M/1338M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 34513: Ranger HDFS/HBase Plugin Upgrade Pack For
HDP-2.2 To HDP-2.3
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34513/#review84647
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On May 20, 2015, 9:08 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34513/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 9:08 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-11289
> https://issues.apache.org/jira/browse/AMBARI-11289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added configuration changes for ranger plugins
> * Added masked attribute for sensitive config changes being written to task stdout.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c5f33c4
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 99d6058
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7505a07
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java c2ea948
>
> Diff: https://reviews.apache.org/r/34513/diff/
>
>
> Testing
> -------
>
> Tests run: 3001, Failures: 0, Errors: 0, Skipped: 21
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:51.152s
> [INFO] Finished at: Wed May 20 20:48:28 EDT 2015
> [INFO] Final Memory: 30M/1338M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 34513: Ranger HDFS/HBase Plugin Upgrade Pack For
HDP-2.2 To HDP-2.3
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34513/
-----------------------------------------------------------
(Updated May 20, 2015, 9:08 p.m.)
Review request for Ambari and Jonathan Hurley.
Bugs: AMBARI-11289
https://issues.apache.org/jira/browse/AMBARI-11289
Repository: ambari
Description
-------
* Added configuration changes for ranger plugins
* Added masked attribute for sensitive config changes being written to task stdout.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java c5f33c4
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java 99d6058
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 7505a07
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ConfigureActionTest.java c2ea948
Diff: https://reviews.apache.org/r/34513/diff/
Testing (updated)
-------
Tests run: 3001, Failures: 0, Errors: 0, Skipped: 21
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:51.152s
[INFO] Finished at: Wed May 20 20:48:28 EDT 2015
[INFO] Final Memory: 30M/1338M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole