You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jake Farrell (JIRA)" <ji...@apache.org> on 2014/09/24 04:00:36 UTC
[jira] [Commented] (THRIFT-2650) add
LoggingRejectedExecutionHandler on ThreadPoolExecutor
[ https://issues.apache.org/jira/browse/THRIFT-2650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145772#comment-14145772 ]
Jake Farrell commented on THRIFT-2650:
--------------------------------------
Can you please rebase against trunk and submit either a pull request or a patch file for this as outlined in [1]
[1]: http://thrift.apache.org/docs/HowToContribute
> add LoggingRejectedExecutionHandler on ThreadPoolExecutor
> ---------------------------------------------------------
>
> Key: THRIFT-2650
> URL: https://issues.apache.org/jira/browse/THRIFT-2650
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.9.1
> Environment: Mac OS
> Reporter: darion yaphets
> Labels: patch
> Fix For: 1.0
>
>
> Add a LoggingRejectedExecutionHandler on ThreadPoolExecutor.
> When ThreadPoolExecutor Server received a unprocess message and make server throw a exception .
> Using RejectedExecutionHandler to avoid the service break down and logging it .
> The git diff as following :
> diff --git a/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java b/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java
> index 488d17f..d0cb4e9 100755
> --- a/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java
> +++ b/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java
> @@ -95,11 +95,18 @@ public class TThreadPoolServer extends TServer {
> private static ExecutorService createDefaultExecutorService(Args args) {
> SynchronousQueue<Runnable> executorQueue =
> new SynchronousQueue<Runnable>();
> + RejectedExecutionHandler loggingHandler = new RejectedExecutionHandler() {
> + @Override
> + public void rejectedExecution(Runnable r,ThreadPoolExecutor executor) {
> + LOGGER.error("Executing Task Failed ...");
> + }
> +
> return new ThreadPoolExecutor(args.minWorkerThreads,
> args.maxWorkerThreads,
> 60,
> TimeUnit.SECONDS,
> - executorQueue);
> + executorQueue,
> + loggingHandler);
> }
> Please review and reply
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)