You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/01 08:19:34 UTC
[GitHub] [camel-k] astefanutti opened a new pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
astefanutti opened a new pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724
This PR takes into account the changes introduced in https://github.com/apache/camel-k-runtime/pull/501.
It fixes CI tests.
**Release Note**
```release-note
NONE
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti edited a comment on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702642406
@nicolaferraro @christophd YAKS call from the Knative workflow had to be changed from an _all directories_ to an _include directories_ with https://github.com/apache/camel-k/commit/e5fdc4ba4b9907b899312947958beca96b0119c3#diff-8bd69437e2586424cb7447c8eed690e7R320-R321. Ideally, the monitoring tests, that can only be run on OpenShift 4, should be excluded, but it seems there is no way to exclude a particular directory from the YAKS CLI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] nicolaferraro commented on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702599134
> It might be possible to do the conversion in the Knative trait. I'm exploring that approach. Even if that is temporary, I'd like to fix CI tests to validate other PRs.
Thanks, I'll change the approach for CamelSource 0.19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702065039
@astefanutti should we bring back the host & port on the runtime part till we change the CamelSource ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti edited a comment on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702647991
@lburgazzoli Thanks, must be that indeed:
```
{
"services":[
{
"type":"event",
"name":"default",
"url":"http://broker-ingress.knative-eventing.svc.cluster.local/camel-k/default",
"metadata":{
"camel.endpoint.kind":"sink",
"knative.apiVersion":"eventing.knative.dev/v1",
"knative.kind":"Broker",
"service.path":"/camel-k/default"
}
}
]
}
```
Does the runtime expect the URL to be _path-less_ or should the `service.path` be simply removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702062344
CamelSource controller creates CamelEnvironment with the old Host and Port fields, so this is more involved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli edited a comment on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
lburgazzoli edited a comment on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702635566
@astefanutti that could be related to a latest change on the runtime so if you set both the `uri` and `path` meta data, they are joined for consistency on producer and consumer side
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti merged pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
astefanutti merged pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702631948
Now that I've got the CamelSource tests working, the `TestRunBroker` e2e test fails 🤕.
It seems the path part gets duplicated for some reasons:
```
Error: dump.go:146: > 2020-10-02 09:17:57,938 WARN [org.apa.cam.com.tim.TimerConsumer] (vert.x-eventloop-thread-0) Error processing exchange. Exchange[8C338EDC8A55717-000000000000024B]. Caused by: [org.apache.camel.CamelException - HTTP operation failed invoking http://broker-ingress.knative-eventing.svc.cluster.local/test-fb340f4a-c955-4254-b03c-dbe275d467d3/default/test-fb340f4a-c955-4254-b03c-dbe275d467d3/default with statusCode: 400, statusMessage: Bad Request]: org.apache.camel.CamelException: HTTP operation failed invoking http://broker-ingress.knative-eventing.svc.cluster.local/test-fb340f4a-c955-4254-b03c-dbe275d467d3/default/test-fb340f4a-c955-4254-b03c-dbe275d467d3/default with statusCode: 400, statusMessage: Bad Request
Error: dump.go:146: > at org.apache.camel.component.knative.http.KnativeHttpProducer.lambda$process$0(KnativeHttpProducer.java:135)
Error: dump.go:146: > at io.vertx.ext.web.client.impl.HttpContext.handleDispatchResponse(HttpContext.java:313)
Error: dump.go:146: > at io.vertx.ext.web.client.impl.HttpContext.execute(HttpContext.java:300)
Error: dump.go:146: > at io.vertx.ext.web.client.impl.HttpContext.next(HttpContext.java:275)
Error: dump.go:146: > at io.vertx.ext.web.client.impl.predicate.PredicateInterceptor.handle(PredicateInterceptor.java:69)
Error: dump.go:146: > at io.vertx.ext.web.client.impl.predicate.PredicateInterceptor.handle(PredicateInterceptor.java:32)
Error: dump.go:146: > at io.vertx.ext.web.client.impl.HttpContext.next(HttpContext.java:272)
Error: dump.go:146: > at io.vertx.ext.web.client.impl.HttpContext.fire(HttpContext.java:282)
Error: dump.go:146: > at io.vertx.ext.web.client.impl.HttpContext.dispatchResponse(HttpContext.java:243)
Error: dump.go:146: > at io.vertx.ext.web.client.impl.HttpContext.lambda$null$2(HttpContext.java:373)
Error: dump.go:146: > at io.vertx.core.impl.ContextImpl.executeTask(ContextImpl.java:366)
Error: dump.go:146: > at io.vertx.core.impl.EventLoopContext.lambda$executeAsync$0(EventLoopContext.java:38)
Error: dump.go:146: > at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
Error: dump.go:146: > at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
Error: dump.go:146: > at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:497)
Error: dump.go:146: > at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
Error: dump.go:146: > at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
Error: dump.go:146: > at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
Error: dump.go:146: > at java.base/java.lang.Thread.run(Thread.java:834)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti edited a comment on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702642406
@nicolaferraro @christophd YAKS call from the Knative workflow had to be changed from an _all directories_ to an _include directories_ with https://github.com/apache/camel-k/commit/e5fdc4ba4b9907b899312947958beca96b0119c3#diff-8bd69437e2586424cb7447c8eed690e7R320-R321. Ideally, the monitoring tests, that can only be run on OpenShift 4, should be excluded, but it seems there is no way to specific an _exclude_ list to the YAKS CLI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli edited a comment on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
lburgazzoli edited a comment on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702065039
@astefanutti @nicolaferraro should we bring back the host & port on the runtime part till we change the CamelSource ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702065721
It might be possible to do the conversion in the Knative trait. I'm exploring that approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702653635
@lburgazzoli thanks, I've removed the extra `path` metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti edited a comment on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702653635
@lburgazzoli thanks, I've removed the redundant `path` metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702642406
@nicolaferraro @christophd YAKS call from the Knative workflow had to be changed from an _all directories_ to an _include directories_ with https://github.com/apache/camel-k/commit/e5fdc4ba4b9907b899312947958beca96b0119c3#diff-8bd69437e2586424cb7447c8eed690e7R320-R321. Ideally, the monitoring tests, that can only be run on OpenShift 4 should be excluded, but it seems there is no way to specific an _exclude_ list to the YAKS CLI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702635566
@astefanutti that could be related to a latest change on the runtime so if you set both the uri and path metadata, they are joined
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702650400
@astefanutti no it assumes that if you provide a path, that info should be used to compute the full URI so you either provide a full `uri` and no `service.path` or you provide a base `path` and `a relative service.path`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702647991
@lburgazzoli Thanks, must be that indeed:
```
{
"services":[
{
"type":"event",
"name":"default",
"url":"http://broker-ingress.knative-eventing.svc.cluster.local/camel-k/default",
"metadata":{
"camel.endpoint.kind":"sink",
"knative.apiVersion":"eventing.knative.dev/v1",
"knative.kind":"Broker",
"service.path":"/camel-k/default"
}
}
]
}
```
Does the runtime expect the URL to be path-less?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti edited a comment on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702065721
It might be possible to do the conversion in the Knative trait. I'm exploring that approach. Even if that is temporary, I'd like to fix CI tests to validate other PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] nicolaferraro commented on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702638567
So, I think there are changes in runtime that should make tests not to pass the "yaks" job.. but I see it green.
(i.e. Kamelet start and end endpoint should be renamed into "kamelet:source" and "kamelet:sink"... "direct:{{routeId}}" should no longer work).
So I've noticed that only two out of 4 dirs are executed by Yaks? Any idea why @christophd ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti edited a comment on pull request #1724: fix: Adapt Knative service definition to new KnativeEnvironment definition
Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on pull request #1724:
URL: https://github.com/apache/camel-k/pull/1724#issuecomment-702647991
@lburgazzoli Thanks, must be that indeed:
```
{
"services":[
{
"type":"event",
"name":"default",
"url":"http://broker-ingress.knative-eventing.svc.cluster.local/camel-k/default",
"metadata":{
"camel.endpoint.kind":"sink",
"knative.apiVersion":"eventing.knative.dev/v1",
"knative.kind":"Broker",
"service.path":"/camel-k/default"
}
}
]
}
```
Does the runtime expect the URL to be _path-less_?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org