You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by ya...@apache.org on 2022/06/15 13:49:13 UTC

[incubator-doris] branch master updated: [improvement] remove unused codes and docs for `SHOW USER` (#10107)

This is an automated email from the ASF dual-hosted git repository.

yangzhg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git


The following commit(s) were added to refs/heads/master by this push:
     new ca88f258d9 [improvement] remove unused codes and docs for `SHOW USER` (#10107)
ca88f258d9 is described below

commit ca88f258d92a24fd86533ac63f4b71fba5561067
Author: camby <10...@qq.com>
AuthorDate: Wed Jun 15 21:49:08 2022 +0800

    [improvement] remove unused codes and docs for `SHOW USER` (#10107)
    
    * remove unused codes and docs for `SHOW USER`
---
 .../sql-reference/Show-Statements/SHOW-USER.md     | 38 ---------------
 .../sql-reference/Show-Statements/SHOW-USER.md     | 42 ----------------
 fe/fe-core/src/main/cup/sql_parser.cup             |  4 --
 .../org/apache/doris/analysis/ShowUserStmt.java    | 57 ----------------------
 regression-test/suites/account/test_account.groovy |  2 +-
 5 files changed, 1 insertion(+), 142 deletions(-)

diff --git a/docs/en/docs/sql-manual/sql-reference/Show-Statements/SHOW-USER.md b/docs/en/docs/sql-manual/sql-reference/Show-Statements/SHOW-USER.md
deleted file mode 100644
index 0efe3e678a..0000000000
--- a/docs/en/docs/sql-manual/sql-reference/Show-Statements/SHOW-USER.md
+++ /dev/null
@@ -1,38 +0,0 @@
----
-{
-    "title": "SHOW-USER",
-    "language": "en"
-}
----
-
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements.  See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership.  The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License.  You may obtain a copy of the License at
-
-  http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied.  See the License for the
-specific language governing permissions and limitations
-under the License.
--->
-
-## SHOW-USER
-
-### Description
-
-### Example
-
-### Keywords
-
-    SHOW, USER
-
-### Best Practice
-
diff --git a/docs/zh-CN/docs/sql-manual/sql-reference/Show-Statements/SHOW-USER.md b/docs/zh-CN/docs/sql-manual/sql-reference/Show-Statements/SHOW-USER.md
deleted file mode 100644
index 1a6ccf098e..0000000000
--- a/docs/zh-CN/docs/sql-manual/sql-reference/Show-Statements/SHOW-USER.md
+++ /dev/null
@@ -1,42 +0,0 @@
----
-{
-    "title": "SHOW-USER",
-    "language": "zh-CN"
-}
----
-
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements.  See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership.  The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License.  You may obtain a copy of the License at
-
-  http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied.  See the License for the
-specific language governing permissions and limitations
-under the License.
--->
-
-## SHOW-USER
-
-### Name
-
-SHOW USER
-
-### Description
-
-### Example
-
-### Keywords
-
-    SHOW, USER
-
-### Best Practice
-
diff --git a/fe/fe-core/src/main/cup/sql_parser.cup b/fe/fe-core/src/main/cup/sql_parser.cup
index aecbef4687..c9494434d9 100644
--- a/fe/fe-core/src/main/cup/sql_parser.cup
+++ b/fe/fe-core/src/main/cup/sql_parser.cup
@@ -2851,10 +2851,6 @@ show_param ::=
     {:
         RESULT = new ShowFrontendsStmt();
     :}
-    | KW_USER
-    {:
-        RESULT = new ShowUserStmt();
-    :}
     | KW_REPOSITORIES
     {:
        RESULT = new ShowRepositoriesStmt();
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/ShowUserStmt.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/ShowUserStmt.java
deleted file mode 100644
index 31754c282a..0000000000
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/ShowUserStmt.java
+++ /dev/null
@@ -1,57 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements.  See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership.  The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License.  You may obtain a copy of the License at
-//
-//   http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied.  See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-package org.apache.doris.analysis;
-
-import org.apache.doris.catalog.Column;
-import org.apache.doris.catalog.ScalarType;
-import org.apache.doris.common.AnalysisException;
-import org.apache.doris.common.proc.AuthProcDir;
-import org.apache.doris.qe.ShowResultSetMetaData;
-
-public class ShowUserStmt extends ShowStmt {
-    private static final ShowResultSetMetaData META_DATA;
-
-    static {
-        ShowResultSetMetaData.Builder builder = ShowResultSetMetaData.builder();
-        for (String title : AuthProcDir.TITLE_NAMES) {
-            builder.addColumn(new Column(title, ScalarType.createVarchar(30)));
-        }
-        META_DATA = builder.build();
-    }
-
-    private String user;
-
-    public ShowUserStmt() {
-
-    }
-
-    public String getUser() {
-        return user;
-    }
-
-    @Override
-    public void analyze(Analyzer analyzer) throws AnalysisException {
-        user = analyzer.getQualifiedUser();
-    }
-
-    @Override
-    public ShowResultSetMetaData getMetaData() {
-        return META_DATA;
-    }
-
-}
diff --git a/regression-test/suites/account/test_account.groovy b/regression-test/suites/account/test_account.groovy
index d830a2027d..ae9f89ed64 100644
--- a/regression-test/suites/account/test_account.groovy
+++ b/regression-test/suites/account/test_account.groovy
@@ -16,5 +16,5 @@
 // under the License.
 suite("test_account", "account") {
     // todo: test account management, such as role, user, grant, revoke ...
-    sql "show user"
+    sql "show roles"
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org