You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "wilfred-s (via GitHub)" <gi...@apache.org> on 2023/05/30 07:32:54 UTC
[GitHub] [yunikorn-site] wilfred-s opened a new pull request, #305: [YUNIKORN-1604] Add K8Shim state dump info
wilfred-s opened a new pull request, #305:
URL: https://github.com/apache/yunikorn-site/pull/305
### What is this PR for?
K8Shim state dump information, high level only as content is not finalised yet.
Upgrade to Docusaurus 2.4.1
### What type of PR is it?
* [X] - Documentation
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1604
### How should this be tested?
Both en and zh-cn site builds should pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] wilfred-s commented on pull request #305: [YUNIKORN-1604] Add K8Shim state dump info
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on PR #305:
URL: https://github.com/apache/yunikorn-site/pull/305#issuecomment-1567915448
Requesting review in both languages before we commit...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] zhuqi-lucas commented on a diff in pull request #305: [YUNIKORN-1604] Add K8Shim state dump info
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on code in PR #305:
URL: https://github.com/apache/yunikorn-site/pull/305#discussion_r1211743598
##########
i18n/zh-cn/docusaurus-plugin-content-docs/current/api/scheduler.md:
##########
@@ -1404,6 +1405,13 @@ checksum: D75996C07D5167F41B33E27CCFAEF1D5C55BE3C00EE6526A7ABDF8435DB4078E
该REST请求的输出将会很巨大，且为前面演示过的输出的组合。
+RM 诊断显示 K8Shim 缓存的内容。确切内容取决于版本并且尚未稳定。
+当前内容显示缓存的对象：
+* 节点
+* 豆荚
Review Comment:
+1 We just need to use Pods here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] 0yukali0 merged pull request #305: [YUNIKORN-1604] Add K8Shim state dump info
Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 merged PR #305:
URL: https://github.com/apache/yunikorn-site/pull/305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] wilfred-s commented on a diff in pull request #305: [YUNIKORN-1604] Add K8Shim state dump info
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on code in PR #305:
URL: https://github.com/apache/yunikorn-site/pull/305#discussion_r1212553715
##########
i18n/zh-cn/docusaurus-plugin-content-docs/current/api/scheduler.md:
##########
@@ -1404,6 +1405,13 @@ checksum: D75996C07D5167F41B33E27CCFAEF1D5C55BE3C00EE6526A7ABDF8435DB4078E
该REST请求的输出将会很巨大，且为前面演示过的输出的组合。
+RM 诊断显示 K8Shim 缓存的内容。确切内容取决于版本并且尚未稳定。
+当前内容显示缓存的对象：
+* 节点
+* 豆荚
Review Comment:
missed that one, I thought I had them all covered :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] 0yukali0 commented on a diff in pull request #305: [YUNIKORN-1604] Add K8Shim state dump info
Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 commented on code in PR #305:
URL: https://github.com/apache/yunikorn-site/pull/305#discussion_r1211656771
##########
i18n/zh-cn/docusaurus-plugin-content-docs/current/api/scheduler.md:
##########
@@ -1404,6 +1405,13 @@ checksum: D75996C07D5167F41B33E27CCFAEF1D5C55BE3C00EE6526A7ABDF8435DB4078E
该REST请求的输出将会很巨大，且为前面演示过的输出的组合。
+RM 诊断显示 K8Shim 缓存的内容。确切内容取决于版本并且尚未稳定。
+当前内容显示缓存的对象：
+* 节点
+* 豆荚
Review Comment:
Pod in the Kubernetes doc doesn't own a translated Chinese word, so I will directly use `Pod`
* Pods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org