You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2024/03/19 15:02:28 UTC
[PR] chore: Pull instead of throw exception in groupBy operator. [incubator-pekko]
He-Pin opened a new pull request, #1210:
URL: https://github.com/apache/incubator-pekko/pull/1210
Motivation:
Fix up a groupby operator bug(issue), and let it just behavior the same as the scaladoc.
>If elements arrive for a stream that is in the process of closing these elements might get lost.
Without this ,the stream is completed with an error.
Result:
The elements associated with the closed sub source is just dropped, and the stream continue, and this will help to keep long live stream in production alive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Pull instead of throw exception in groupBy operator. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1210:
URL: https://github.com/apache/incubator-pekko/pull/1210#issuecomment-2007572969
@mdedetrich Wdyt about this, should we include it in 1.1.0-m1? I think it's ok in M2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Pull instead of throw exception in groupBy operator. [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1210:
URL: https://github.com/apache/incubator-pekko/pull/1210#issuecomment-2007531663
Can't be merged until M1 is released. Unless we agree to bring it into M1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Pull instead of throw exception in groupBy operator. [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1210:
URL: https://github.com/apache/incubator-pekko/pull/1210#issuecomment-2007817981
@pjfanning wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Pull instead of throw exception in groupBy operator. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1210:
URL: https://github.com/apache/incubator-pekko/pull/1210#issuecomment-2007772338
That is why I do this asap，+1 for have it in m1 too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Pull instead of throw exception in groupBy operator. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1210:
URL: https://github.com/apache/incubator-pekko/pull/1210#issuecomment-2008621304
Thanks for detail review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Pull instead of throw exception in groupBy operator. [incubator-pekko]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #1210:
URL: https://github.com/apache/incubator-pekko/pull/1210#issuecomment-2007457861
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Pull instead of throw exception in groupBy operator. [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #1210:
URL: https://github.com/apache/incubator-pekko/pull/1210#issuecomment-2007650996
After having the recent conversation at https://lists.apache.org/thread/rjygk60ho1mojk4rqsmvd2y4244d55lr I think its best to put as many changes as we can in `-M1` to avoid an `-M2` if possible (i.e. there may be some bug fixes after `-M1` but nothing drastic like new features).
That is my view but I am not going to push hard on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Pull instead of throw exception in groupBy operator. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1210:
URL: https://github.com/apache/incubator-pekko/pull/1210#discussion_r1530572707
##########
stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowGroupBySpec.scala:
##########
@@ -694,6 +692,19 @@ class FlowGroupBySpec extends StreamSpec("""
queue.complete()
}
+ "should not fail when one sub stream completed" in {
+ Source(1 to 10)
+ .groupBy(2, _ % 2, allowClosedSubstreamRecreation = false)
+ .take(2)
Review Comment:
The sub stream is limited to 2, after that, the elements is skiped and keep pulling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Pull instead of throw exception in groupBy operator. [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #1210:
URL: https://github.com/apache/incubator-pekko/pull/1210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org