[jira] [Commented] (MESOS-3409) Refactor the plain JSON parsing in the docker containerizer

["Timothy Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739305#comment-14739305 ] 

Timothy Chen commented on MESOS-3409:
-------------------------------------

We're actualy adding more of this with the registry client. I think we'll add tickets on the registry client to do that.

> Refactor the plain JSON parsing in the docker containerizer
> -----------------------------------------------------------
>
>                 Key: MESOS-3409
>                 URL: https://issues.apache.org/jira/browse/MESOS-3409
>             Project: Mesos
>          Issue Type: Improvement
>          Components: docker
>            Reporter: Joseph Wu
>            Assignee: Joseph Wu
>            Priority: Minor
>
> Two functions in the Docker-related code take a string and parse it to JSON:
> * {{Docker::Container::create}} in {{src/docker/docker.cpp}}
> * {{Token::create}} in {{src/slave/containerizer/provisioners/docker/token_manager.cpp}}
> This JSON is then validated (lots of if-elses) and used via the {{JSON::Value}} accessors.  We could instead use a protobuf and the related Stout JSON->Protobuf conversion function.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)