You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "syvalta (JIRA)" <ji...@apache.org> on 2008/09/03 08:25:45 UTC

[jira] Created: (DIRMINA-619) Mark easymock as test dependency in maven pom.xml

Mark easymock as test dependency in maven pom.xml
-------------------------------------------------

                 Key: DIRMINA-619
                 URL: https://issues.apache.org/jira/browse/DIRMINA-619
             Project: MINA
          Issue Type: Improvement
          Components: Core
    Affects Versions: 2.0.0-M3
            Reporter: syvalta


Currently Maven pom.xml for core includes following dependencies:

    <dependency>
      <groupId>org.easymock</groupId>
      <artifactId>easymock</artifactId>
    </dependency>
    
    <dependency>
      <groupId>org.easymock</groupId>
      <artifactId>easymockclassextension</artifactId>
    </dependency>

I would assume that they are test dependencies, so adding <scope>test</scope> to them would be good to prevent them to be included in wars etc. Unless I'm mistaken and they really are needed at runtime, which I find highly unlikely. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-619) Mark easymock as test dependency in maven pom.xml

Posted by "Edouard De Oliveira (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627953#action_12627953 ] 

Edouard De Oliveira commented on DIRMINA-619:
---------------------------------------------

I don't think so . trunk also seems not to be affected by this issue maybe a previous version is ... i didn't check.
So please update to latest release

> Mark easymock as test dependency in maven pom.xml
> -------------------------------------------------
>
>                 Key: DIRMINA-619
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-619
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-M3
>            Reporter: syvalta
>
> Currently Maven pom.xml for core includes following dependencies:
>     <dependency>
>       <groupId>org.easymock</groupId>
>       <artifactId>easymock</artifactId>
>     </dependency>
>     
>     <dependency>
>       <groupId>org.easymock</groupId>
>       <artifactId>easymockclassextension</artifactId>
>     </dependency>
> I would assume that they are test dependencies, so adding <scope>test</scope> to them would be good to prevent them to be included in wars etc. Unless I'm mistaken and they really are needed at runtime, which I find highly unlikely. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DIRMINA-619) Mark easymock as test dependency in maven pom.xml

Posted by "syvalta (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DIRMINA-619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

syvalta closed DIRMINA-619.
---------------------------

    Resolution: Invalid

Ah, sorry for the noise.

> Mark easymock as test dependency in maven pom.xml
> -------------------------------------------------
>
>                 Key: DIRMINA-619
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-619
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-M3
>            Reporter: syvalta
>
> Currently Maven pom.xml for core includes following dependencies:
>     <dependency>
>       <groupId>org.easymock</groupId>
>       <artifactId>easymock</artifactId>
>     </dependency>
>     
>     <dependency>
>       <groupId>org.easymock</groupId>
>       <artifactId>easymockclassextension</artifactId>
>     </dependency>
> I would assume that they are test dependencies, so adding <scope>test</scope> to them would be good to prevent them to be included in wars etc. Unless I'm mistaken and they really are needed at runtime, which I find highly unlikely. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-619) Mark easymock as test dependency in maven pom.xml

Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628277#action_12628277 ] 

Emmanuel Lecharny commented on DIRMINA-619:
-------------------------------------------

Hey,

this was certainly not noise ! We really appreciate those kind of reports. This is the way to go, definitively : we can quickly check if it's a real bug or not, and if not, we simply close the JIRA. It's a 5 minutes process, and it's asynchronous, compared to a mail which must be processed quick immediatly, or forgetten for ever...

Thanks !

> Mark easymock as test dependency in maven pom.xml
> -------------------------------------------------
>
>                 Key: DIRMINA-619
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-619
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-M3
>            Reporter: syvalta
>
> Currently Maven pom.xml for core includes following dependencies:
>     <dependency>
>       <groupId>org.easymock</groupId>
>       <artifactId>easymock</artifactId>
>     </dependency>
>     
>     <dependency>
>       <groupId>org.easymock</groupId>
>       <artifactId>easymockclassextension</artifactId>
>     </dependency>
> I would assume that they are test dependencies, so adding <scope>test</scope> to them would be good to prevent them to be included in wars etc. Unless I'm mistaken and they really are needed at runtime, which I find highly unlikely. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-619) Mark easymock as test dependency in maven pom.xml

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627963#action_12627963 ] 

Niklas Gustavsson commented on DIRMINA-619:
-------------------------------------------

They are already scoped as test in the parent POM:
      <dependency>
        <groupId>org.easymock</groupId>
        <artifactId>easymock</artifactId>
        <version>2.3</version>
        <scope>test</scope>
      </dependency>

      <dependency>
        <groupId>org.easymock</groupId>
        <artifactId>easymockclassextension</artifactId>
        <version>2.3</version>
        <scope>test</scope>
      </dependency>

As a downstream user of MINA in FtpServer, I don't get these included as transitive dependencies so I think the scoping work as expected.

> Mark easymock as test dependency in maven pom.xml
> -------------------------------------------------
>
>                 Key: DIRMINA-619
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-619
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-M3
>            Reporter: syvalta
>
> Currently Maven pom.xml for core includes following dependencies:
>     <dependency>
>       <groupId>org.easymock</groupId>
>       <artifactId>easymock</artifactId>
>     </dependency>
>     
>     <dependency>
>       <groupId>org.easymock</groupId>
>       <artifactId>easymockclassextension</artifactId>
>     </dependency>
> I would assume that they are test dependencies, so adding <scope>test</scope> to them would be good to prevent them to be included in wars etc. Unless I'm mistaken and they really are needed at runtime, which I find highly unlikely. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DIRMINA-619) Mark easymock as test dependency in maven pom.xml

Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DIRMINA-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627923#action_12627923 ] 

Julien Vermillard commented on DIRMINA-619:
-------------------------------------------

after checking maven dependencies report : http://mina.apache.org/report/trunk/mina-core/dependencies.html
look like they are correctly scoped as test.
Am I making a mistake there ?

> Mark easymock as test dependency in maven pom.xml
> -------------------------------------------------
>
>                 Key: DIRMINA-619
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-619
>             Project: MINA
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0.0-M3
>            Reporter: syvalta
>
> Currently Maven pom.xml for core includes following dependencies:
>     <dependency>
>       <groupId>org.easymock</groupId>
>       <artifactId>easymock</artifactId>
>     </dependency>
>     
>     <dependency>
>       <groupId>org.easymock</groupId>
>       <artifactId>easymockclassextension</artifactId>
>     </dependency>
> I would assume that they are test dependencies, so adding <scope>test</scope> to them would be good to prevent them to be included in wars etc. Unless I'm mistaken and they really are needed at runtime, which I find highly unlikely. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.