You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/04/22 07:00:37 UTC

[GitHub] [rocketmq] RongtongJin commented on pull request #2707: [ISSUE #2706] Fix the problem of returning SEND_OK after flush failed

RongtongJin commented on pull request #2707:
URL: https://github.com/apache/rocketmq/pull/2707#issuecomment-824592777


   > > Good catch! But I feel that the change is a bit complicated. When the flushing error occurs, the location flushedPosition does not move and will return to the client FLUSH_DISK_TIMEOUT.
   > 
   > **this.flushedPosition.set(value);**
   > You can see that this line of code will be executed no matter what。So even if an error is reported, the position will change。
   
   You're right. But when an exception is thrown, we can not set  flushedPosition.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org