[GitHub] [incubator-mxnet] szha commented on a change in pull request #19034: Switch to GCC 9 for static build

[GitBox <gi...@apache.org>]

szha commented on a change in pull request #19034:
URL: https://github.com/apache/incubator-mxnet/pull/19034#discussion_r484229029



##########
File path: tools/pip/setup.py
##########
@@ -152,9 +152,12 @@ def skip_markdown_comments(md):
     if os.path.exists(os.path.join(libdir, 'libgfortran.so.3')):
         shutil.copy(os.path.join(libdir, 'libgfortran.so.3'), mxdir)
         package_data['mxnet'].append('mxnet/libgfortran.so.3')
-    else:
+    elif os.path.exists(os.path.join(libdir, 'libgfortran.so.4')):
         shutil.copy(os.path.join(libdir, 'libgfortran.so.4'), mxdir)
         package_data['mxnet'].append('mxnet/libgfortran.so.4')
+    else:
+        shutil.copy(os.path.join(libdir, 'libgfortran.so.5'), mxdir)
+        package_data['mxnet'].append('mxnet/libgfortran.so.5')

Review comment:
       it's possible that user compiled and statically linked libgfortran or this file isn't necessary, so I'd recommend to add the condition check.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org