You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:06:54 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #3691: Upgrade `arrow` `parquet` and `arrow-flight` to 24.0.0
alamb opened a new pull request, #3691:
URL: https://github.com/apache/arrow-datafusion/pull/3691
Draft until
- [ ] arrow `24.0.0` is released https://github.com/apache/arrow-rs/issues/2759
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/3689
# Rationale for this change
Keep up with upstream changes
# What changes are included in this PR?
1. Update to arrow
2. Update for API changes
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3691: Upgrade `arrow` `parquet` and `arrow-flight` to 24.0.0
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3691:
URL: https://github.com/apache/arrow-datafusion/pull/3691#discussion_r985968163
##########
datafusion/common/src/pyarrow.rs:
##########
@@ -43,16 +43,16 @@ impl PyArrowConvert for ScalarValue {
let array = factory.call1((args, typ))?;
// convert the pyarrow array to rust array using C data interface
- let array = array.extract::<ArrayData>()?;
- let scalar = ScalarValue::try_from_array(&array.into(), 0)?;
+ let array = arrow::array::make_array(ArrayData::from_pyarrow(array)?);
Review Comment:
Needed due to changes in https://github.com/apache/arrow-rs/pull/2769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org