You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/02/08 10:25:22 UTC
[GitHub] [ozone] guohao-rosicky opened a new pull request #3055: HDDS-6283. Change ContainerStateMachine ContainerOpExecutor name
guohao-rosicky opened a new pull request #3055:
URL: https://github.com/apache/ozone/pull/3055
## What changes were proposed in this pull request?
Change ContainerStateMachine ContainerOpExecutor name
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lokeshj1703 commented on a change in pull request #3055: HDDS-6283. Change ContainerStateMachine ContainerOpExecutor name
Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on a change in pull request #3055:
URL: https://github.com/apache/ozone/pull/3055#discussion_r804394858
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
##########
@@ -197,7 +198,11 @@ public ContainerStateMachine(RaftGroupId gid, ContainerDispatcher dispatcher,
applyTransactionSemaphore = new Semaphore(maxPendingApplyTransactions);
stateMachineHealthy = new AtomicBoolean(true);
- this.executor = Executors.newFixedThreadPool(numContainerOpExecutors);
+ this.executor = Executors.newFixedThreadPool(numContainerOpExecutors,
+ new ThreadFactoryBuilder()
+ .setNameFormat("ContainerOP-" + gid.getUuid() + "-%d")
Review comment:
```suggestion
.setNameFormat("ContainerOp-" + gid.getUuid() + "-%d")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guohao-rosicky commented on a change in pull request #3055: HDDS-6283. Change ContainerStateMachine ContainerOpExecutor name
Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on a change in pull request #3055:
URL: https://github.com/apache/ozone/pull/3055#discussion_r806408659
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
##########
@@ -197,7 +198,11 @@ public ContainerStateMachine(RaftGroupId gid, ContainerDispatcher dispatcher,
applyTransactionSemaphore = new Semaphore(maxPendingApplyTransactions);
stateMachineHealthy = new AtomicBoolean(true);
- this.executor = Executors.newFixedThreadPool(numContainerOpExecutors);
+ this.executor = Executors.newFixedThreadPool(numContainerOpExecutors,
+ new ThreadFactoryBuilder()
+ .setNameFormat("ContainerOP-" + gid.getUuid() + "-%d")
Review comment:
Has been modified, @lokeshj1703 Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guohao-rosicky commented on a change in pull request #3055: HDDS-6283. Change ContainerStateMachine ContainerOpExecutor name
Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on a change in pull request #3055:
URL: https://github.com/apache/ozone/pull/3055#discussion_r806408659
##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
##########
@@ -197,7 +198,11 @@ public ContainerStateMachine(RaftGroupId gid, ContainerDispatcher dispatcher,
applyTransactionSemaphore = new Semaphore(maxPendingApplyTransactions);
stateMachineHealthy = new AtomicBoolean(true);
- this.executor = Executors.newFixedThreadPool(numContainerOpExecutors);
+ this.executor = Executors.newFixedThreadPool(numContainerOpExecutors,
+ new ThreadFactoryBuilder()
+ .setNameFormat("ContainerOP-" + gid.getUuid() + "-%d")
Review comment:
Has been modified, @lokeshj1703 Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lokeshj1703 commented on pull request #3055: HDDS-6283. Change ContainerStateMachine ContainerOpExecutor name
Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on pull request #3055:
URL: https://github.com/apache/ozone/pull/3055#issuecomment-1042655981
Thanks @guohao-rosicky for the contribution! I have committed the PR to master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lokeshj1703 merged pull request #3055: HDDS-6283. Change ContainerStateMachine ContainerOpExecutor name
Posted by GitBox <gi...@apache.org>.
lokeshj1703 merged pull request #3055:
URL: https://github.com/apache/ozone/pull/3055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guohao-rosicky commented on pull request #3055: HDDS-6283. Change ContainerStateMachine ContainerOpExecutor name
Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on pull request #3055:
URL: https://github.com/apache/ozone/pull/3055#issuecomment-1033362727
@lokeshj1703 Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guohao-rosicky commented on pull request #3055: HDDS-6283. Change ContainerStateMachine ContainerOpExecutor name
Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on pull request #3055:
URL: https://github.com/apache/ozone/pull/3055#issuecomment-1042626207
Has been modified, @lokeshj1703 Please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org