You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/10/18 23:40:33 UTC

[Impala-ASF-CR] IMPALA-11671: Clear trash for Ozone to avoid bug

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19151


Change subject: IMPALA-11671: Clear trash for Ozone to avoid bug
......................................................................

IMPALA-11671: Clear trash for Ozone to avoid bug

When using Ozone, clears trash before listing it after running tests to
avoid HDDS-4974. It seems to come up specifically for files generated by
query_test/test_cancellation.py and query_test/test_decimal_queries.py.

Change-Id: I3dfdac33484cc4a033a81943c655928b8c5b24b0
---
M bin/run-all-tests.sh
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/19151/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3dfdac33484cc4a033a81943c655928b8c5b24b0
Gerrit-Change-Number: 19151
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-11671: Clear trash for Ozone to avoid bug

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19151 )

Change subject: IMPALA-11671: Clear trash for Ozone to avoid bug
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8724/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/19151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dfdac33484cc4a033a81943c655928b8c5b24b0
Gerrit-Change-Number: 19151
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Oct 2022 22:29:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11671: Clear trash for Ozone to avoid bug

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19151 )

Change subject: IMPALA-11671: Clear trash for Ozone to avoid bug
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dfdac33484cc4a033a81943c655928b8c5b24b0
Gerrit-Change-Number: 19151
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Oct 2022 21:59:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11671: Clear trash for Ozone to avoid bug

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19151 )

Change subject: IMPALA-11671: Clear trash for Ozone to avoid bug
......................................................................

IMPALA-11671: Clear trash for Ozone to avoid bug

When using Ozone, clears trash before listing it after running tests to
avoid HDDS-4974. It seems to come up specifically for files generated by
query_test/test_cancellation.py and query_test/test_decimal_queries.py.

Change-Id: I3dfdac33484cc4a033a81943c655928b8c5b24b0
Reviewed-on: http://gerrit.cloudera.org:8080/19151
Reviewed-by: Daniel Becker <da...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/run-all-tests.sh
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Daniel Becker: Looks good to me, but someone else must approve
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3dfdac33484cc4a033a81943c655928b8c5b24b0
Gerrit-Change-Number: 19151
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-11671: Clear trash for Ozone to avoid bug

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19151 )

Change subject: IMPALA-11671: Clear trash for Ozone to avoid bug
......................................................................


Patch Set 1: Code-Review+2

This makes sense to me


-- 
To view, visit http://gerrit.cloudera.org:8080/19151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dfdac33484cc4a033a81943c655928b8c5b24b0
Gerrit-Change-Number: 19151
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Oct 2022 22:20:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11671: Clear trash for Ozone to avoid bug

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19151 )

Change subject: IMPALA-11671: Clear trash for Ozone to avoid bug
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11660/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dfdac33484cc4a033a81943c655928b8c5b24b0
Gerrit-Change-Number: 19151
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Oct 2022 00:00:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11671: Clear trash for Ozone to avoid bug

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19151 )

Change subject: IMPALA-11671: Clear trash for Ozone to avoid bug
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19151
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dfdac33484cc4a033a81943c655928b8c5b24b0
Gerrit-Change-Number: 19151
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Oct 2022 03:36:08 +0000
Gerrit-HasComments: No