[GitHub] [phoenix] jpisaac commented on a change in pull request #599: Create columns in SYSCAT and fields in PTable.proto for view TTL support

[GitBox <gi...@apache.org>]

jpisaac commented on a change in pull request #599: Create columns in SYSCAT and fields in PTable.proto for view TTL support
URL: https://github.com/apache/phoenix/pull/599#discussion_r337617073
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewTTLIT.java
 ##########
 @@ -0,0 +1,111 @@
+package org.apache.phoenix.end2end;
+
+import com.google.common.collect.Lists;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.filter.*;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.phoenix.jdbc.PhoenixDatabaseMetaData;
+import org.apache.phoenix.query.PhoenixTestBuilder;
+import org.apache.phoenix.query.QueryConstants;
+import org.apache.phoenix.util.SchemaUtil;
+import org.apache.phoenix.util.TestUtil;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.SQLException;
+import java.util.List;
+
+import static org.junit.Assert.assertEquals;
+
+public class ViewTTLIT extends ParallelStatsDisabledIT {
+
+    private static final Logger LOGGER = LoggerFactory.getLogger(ViewTTLIT.class);
+
+    // Scans the HBase rows directly for the view ttl related header rows column and asserts
+    private void assertViewHeaderRowsHaveViewTTLRelatedCells(String schemaName, long minTimestamp,
+            int expectedRows) throws IOException, SQLException {
+
+        FilterList filterList = new FilterList(FilterList.Operator.MUST_PASS_ALL);
+        RowFilter schemaNameFilter = new RowFilter(
+                CompareFilter.CompareOp.EQUAL,
+                new SubstringComparator(schemaName)
+        );
+        ColumnPrefixFilter viewTTLPrefixFilter = new ColumnPrefixFilter(PhoenixDatabaseMetaData.VIEW_TTL_BYTES);
+        filterList.addFilter(schemaNameFilter);
+        filterList.addFilter(viewTTLPrefixFilter);
+        try (Table tbl = driver.getConnectionQueryServices(getUrl(), TestUtil.TEST_PROPERTIES)
+                .getTable(PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME_BYTES)) {
+
+            Scan allRows = new Scan();
+            allRows.setRaw(true);
+            allRows.setTimeRange(minTimestamp, HConstants.LATEST_TIMESTAMP);
+            allRows.setFilter(filterList);
+            ResultScanner scanner = tbl.getScanner(allRows);
+            int numMatchingRows = 0;
+            for (Result result = scanner.next(); result != null; result = scanner.next()) {
+                numMatchingRows +=
+                        result.containsColumn(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES,
+                                PhoenixDatabaseMetaData.VIEW_TTL_BYTES) ? 1 : 0;
+            }
+            assertEquals(String.format("Expected rows do match for table = %s at timestamp %d",
+                    Bytes.toString(PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME_BYTES), minTimestamp), expectedRows, numMatchingRows);
+        }
+
+    }
+
+    /**
+         * -----------------
+         * Test methods
+         * -----------------
+         */
+
+    @Test
+    public void testWithBasicTenantViewWithNoViewTTLDefined() throws Exception {
+
+        long startTime = System.currentTimeMillis();
+        // Define the test schema.
+        PhoenixTestBuilder.SchemaBuilder.TableOptions
+                tableOptions = PhoenixTestBuilder.SchemaBuilder.TableOptions.withDefaults();
+        tableOptions.getTablePKColumns().add("ID");
+        tableOptions.getTablePKColumnTypes().add("CHAR(15)");
+        tableOptions.getTableColumns().clear();
+        tableOptions.getTableColumnTypes().clear();
+
+        final PhoenixTestBuilder.SchemaBuilder schemaBuilder = new PhoenixTestBuilder.SchemaBuilder(getUrl());
+        schemaBuilder.withTableOptions(tableOptions).build();
+
+        // Define the test data.
+        PhoenixTestBuilder.DataSupplier dataSupplier = new PhoenixTestBuilder.DataSupplier() {
+
+            final String
+                    orgId =
+                    String.format("00D0x000%s", schemaBuilder.getDataOptions().getUniqueName());
+            final String kp = SchemaUtil.normalizeIdentifier(schemaBuilder.getEntityKeyPrefix());
+
+            @Override public List<Object> getValues(int rowIndex) {
+                String id = String.format("00A0y000%07d", rowIndex);
 
 Review comment:
   Nothing special! Just trying to get char(15) id, just using the sfdc id format.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services