You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/04/23 01:10:41 UTC

[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #267: [YUNIKORN-645] Metrics endpoint doesn't export any metrics

wilfred-s commented on pull request #267:
URL: https://github.com/apache/incubator-yunikorn-core/pull/267#issuecomment-825313229


   I think we need to wind back the introduction of the `YResponseWriter` If there are calls that need specific handling of the errors then that should be part of the defined `HandlerFunc` which we specify in the web routes. We can still use a predefined error mechanism to get the details.
   Beside the issue that was mentioned by @yangwwei for the other _successful_ status codes I can also see an issue around error handling and non success codes. If we set `http.StatusInternalServerError` because we have encountered a problem when writing the body via the json encoder, we try to redo that same thing again. Similar for any error in the 400 range.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org