You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2024/01/19 05:01:21 UTC

[PR] ORC-1597: [C++] Set bloom filter fpp to 1% [orc]

cxzl25 opened a new pull request, #1764:
URL: https://github.com/apache/orc/pull/1764

   ### What changes were proposed in this pull request?
   Set the bloom filter fpp to 1% in C++ Writer.
   
   ### Why are the changes needed?
   Java Writer changed `orc.bloom.filter.fpp` to 0.01 in ORC-1338, C++ Writer is still 0.05.
   
   ### How was this patch tested?
   GA
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ORC-1597: [C++] Set bloom filter fpp to 1% [orc]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1764:
URL: https://github.com/apache/orc/pull/1764#issuecomment-1901004214

   Thank you, @cxzl25 !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ORC-1597: [C++] Set bloom filter fpp to 1% [orc]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #1764: ORC-1597: [C++] Set bloom filter fpp to 1%
URL: https://github.com/apache/orc/pull/1764


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org