Re: cvs commit: avalon-excalibur/fortress/src/java/org/apache/avalon/fortress/util/dag Vertex.java

[Leo Simons <le...@apache.org>]

Berin Loritsch wrote:
> leif@apache.org wrote:
>>   Log:
>>   Rework the way the Directed Graph is validated and sorted so it 
>> works correctly.
>>   This new method also maintains all of the information necessary to 
>> be able to
>>   display a useful description of any cyclic loops in the graph if 
>> they are detected.
> 
> Leif, I already fixed this, unless you can produce a bug, could you
> please revert back to the way it was?
> 
> The algorithm is very efficient as it checks each edge (relationship
> between verteces) only once and still detects circular dependencies.

as a general rule, premature optimization is the root of all evil, innit?

I would say that unless you can produce an efficiency test which shows 
the old implementation to be faster, functionality in general overrules 
speed?

back into hiding....

- LSD



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@avalon.apache.org
For additional commands, e-mail: dev-help@avalon.apache.org