You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by bm...@apache.org on 2021/06/01 10:07:06 UTC
[maven-dependency-plugin] 01/02: fixed MDEP-568: instead of relying
on "requiresDependencyResolution" to download artifacts,
download the artifacts in the plugin code after filtering them with the
provided parameters.
This is an automated email from the ASF dual-hosted git repository.
bmarwell pushed a commit to branch MDEP-568_go-offline_filter
in repository https://gitbox.apache.org/repos/asf/maven-dependency-plugin.git
commit e10681c87a3e6ed013e1f92f5d4e47fbefbad6ff
Author: Andreas Janning <an...@qaware.de>
AuthorDate: Mon Jul 16 16:20:11 2018 -0700
fixed MDEP-568: instead of relying on "requiresDependencyResolution" to download artifacts, download the artifacts
in the plugin code after filtering them with the provided parameters.
---
.../mdep-568-go-offline-exclude/invoker.properties | 18 +++++++
.../projects/mdep-568-go-offline-exclude/pom.xml | 57 ++++++++++++++++++++++
.../mdep-568-go-offline-exclude/test.properties | 19 ++++++++
.../dependency/resolvers/GoOfflineMojo.java | 33 +++++++++----
4 files changed, 117 insertions(+), 10 deletions(-)
diff --git a/src/it/projects/mdep-568-go-offline-exclude/invoker.properties b/src/it/projects/mdep-568-go-offline-exclude/invoker.properties
new file mode 100644
index 0000000..e596121
--- /dev/null
+++ b/src/it/projects/mdep-568-go-offline-exclude/invoker.properties
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+invoker.goals = ${project.groupId}:${project.artifactId}:${project.version}:go-offline
diff --git a/src/it/projects/mdep-568-go-offline-exclude/pom.xml b/src/it/projects/mdep-568-go-offline-exclude/pom.xml
new file mode 100644
index 0000000..a69b7b8
--- /dev/null
+++ b/src/it/projects/mdep-568-go-offline-exclude/pom.xml
@@ -0,0 +1,57 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <groupId>org.apache.maven.its.dependency</groupId>
+ <artifactId>test</artifactId>
+ <version>1.0-SNAPSHOT</version>
+
+ <name>Test</name>
+ <description>
+ Test dependency:go-offline
+ </description>
+
+ <properties>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-project</artifactId>
+ <version>2.0.6</version>
+ </dependency>
+ <dependency>
+ <groupId>non.existant.group</groupId>
+ <artifactId>fake</artifactId>
+ <version>1.0.0</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>non.existant.artifact</artifactId>
+ <version>1.0.0</version>
+ </dependency>
+ </dependencies>
+
+</project>
diff --git a/src/it/projects/mdep-568-go-offline-exclude/test.properties b/src/it/projects/mdep-568-go-offline-exclude/test.properties
new file mode 100644
index 0000000..6e8a5e5
--- /dev/null
+++ b/src/it/projects/mdep-568-go-offline-exclude/test.properties
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+excludeGroupIds = non.existant.group
+excludeArtifactIds= non.existant.artifact
diff --git a/src/main/java/org/apache/maven/plugins/dependency/resolvers/GoOfflineMojo.java b/src/main/java/org/apache/maven/plugins/dependency/resolvers/GoOfflineMojo.java
index e0e8b1f..1861c00 100644
--- a/src/main/java/org/apache/maven/plugins/dependency/resolvers/GoOfflineMojo.java
+++ b/src/main/java/org/apache/maven/plugins/dependency/resolvers/GoOfflineMojo.java
@@ -19,12 +19,20 @@ package org.apache.maven.plugins.dependency.resolvers;
* under the License.
*/
+import java.util.Collection;
+import java.util.HashSet;
+import java.util.LinkedHashSet;
+import java.util.Set;
+
import org.apache.maven.artifact.Artifact;
import org.apache.maven.artifact.repository.ArtifactRepository;
import org.apache.maven.model.Dependency;
import org.apache.maven.plugin.MojoExecutionException;
-import org.apache.maven.plugins.dependency.utils.DependencyUtil;
+import org.apache.maven.plugins.annotations.Execute;
import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import org.apache.maven.plugins.annotations.ResolutionScope;
+import org.apache.maven.plugins.dependency.utils.DependencyUtil;
import org.apache.maven.project.ProjectBuildingRequest;
import org.apache.maven.shared.artifact.filter.collection.ArtifactsFilter;
import org.apache.maven.shared.artifact.filter.resolve.TransformableFilter;
@@ -33,25 +41,30 @@ import org.apache.maven.shared.transfer.dependencies.DefaultDependableCoordinate
import org.apache.maven.shared.transfer.dependencies.DependableCoordinate;
import org.apache.maven.shared.transfer.dependencies.resolve.DependencyResolverException;
-import java.util.Collection;
-import java.util.HashSet;
-import java.util.LinkedHashSet;
-import java.util.Set;
-
/**
* Goal that resolves all project dependencies, including plugins and reports and their dependencies.
*
- * <a href="mailto:brianf@apache.org">Brian Fox</a>
+ * @author <a href="mailto:brianf@apache.org">Brian Fox</a>
* @author Maarten Mulders
* @since 2.0
*/
-@Mojo( name = "go-offline", threadSafe = true )
+@Mojo( name = "go-offline", requiresDependencyCollection = ResolutionScope.TEST, threadSafe = true )
+@Execute( goal = "resolve-plugins" )
public class GoOfflineMojo
extends AbstractResolveMojo
{
/**
- * Main entry into mojo. Gets the list of dependencies, resolves all that are not in the Reactor, and iterates
- * through displaying the resolved versions.
+ * Include parent poms in the dependency resolution list.
+ *
+ * @since 3.1.2
+ */
+ @Parameter( property = "includeParents", defaultValue = "false" )
+ private boolean includeParents;
+
+ /**
+ * Main entry into mojo. Gets the list of dependencies, filters them by the include/exclude parameters
+ * provided and iterates through downloading the resolved version.
+ * if the version is not present in the local repository.
*
* @throws MojoExecutionException with a message if an error occurs.
*/