You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2017/11/27 19:19:19 UTC
[GitHub] spark pull request #19829: [WIP]Upgrade Netty to 4.1.17
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/19829
[WIP]Upgrade Netty to 4.1.17
## What changes were proposed in this pull request?
Submitted this PR to see if there is anything broken.
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark netty-4.1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19829.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19829
----
commit 14dbc71ac9be7d027b8d2d008f3a1350e5012dd1
Author: Shixiong Zhu <zs...@gmail.com>
Date: 2017-11-27T18:57:16Z
Upgrade Netty to 4.1.17
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19829
**[Test build #84231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84231/testReport)** for PR 19829 at commit [`93632a0`](https://github.com/apache/spark/commit/93632a071b5eef1f4d2882f547c43ed0750b1450).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19829
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19829
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19829
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84226/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19829
**[Test build #84668 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84668/testReport)** for PR 19829 at commit [`94df9ae`](https://github.com/apache/spark/commit/94df9ae0bf5216f70c17b8aed297cda22f9566f4).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19829
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19829: [WIP]Upgrade Netty to 4.1.17
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/19829#discussion_r155904309
--- Diff: common/network-common/src/main/java/org/apache/spark/network/crypto/TransportCipher.java ---
@@ -203,6 +203,63 @@ public long transfered() {
return transferred;
}
+ @Override
--- End diff --
Good point! Updated!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19829
**[Test build #84671 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84671/testReport)** for PR 19829 at commit [`96df5f2`](https://github.com/apache/spark/commit/96df5f26d163a4a17d8ab824995b57992afa6b8b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class MessageWithHeader extends AbstractFileRegion `
* ` static class EncryptedMessage extends AbstractFileRegion `
* `public abstract class AbstractFileRegion extends AbstractReferenceCounted implements FileRegion `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19829
**[Test build #84671 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84671/testReport)** for PR 19829 at commit [`96df5f2`](https://github.com/apache/spark/commit/96df5f26d163a4a17d8ab824995b57992afa6b8b).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19829
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84231/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19829
**[Test build #84226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84226/testReport)** for PR 19829 at commit [`14dbc71`](https://github.com/apache/spark/commit/14dbc71ac9be7d027b8d2d008f3a1350e5012dd1).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19829
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84668/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19829
**[Test build #84669 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84669/testReport)** for PR 19829 at commit [`9a07d2b`](https://github.com/apache/spark/commit/9a07d2b64c506a6d822dea27ca76255c084569f4).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19829
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19829: [WIP]Upgrade Netty to 4.1.17
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19829#discussion_r155115222
--- Diff: common/network-common/src/main/java/org/apache/spark/network/crypto/TransportCipher.java ---
@@ -203,6 +203,63 @@ public long transfered() {
return transferred;
}
+ @Override
--- End diff --
I prototyped this change internally for a different reason, and I chose to create an abstract class for all this boilerplate, which seems cleaner to me.
```
public abstract class AbstractFileRegion extends AbstractReferenceCounted implements FileRegion {
@Override
@SuppressWarnings("deprecation")
public final long transfered() {
return transferred();
}
@Override
public FileRegion retain() {
super.retain();
return this;
}
@Override
public FileRegion retain(int increment) {
super.retain(increment);
return this;
}
@Override
public FileRegion touch() {
return touch(null);
}
@Override
public FileRegion touch(Object hint) {
return this;
}
}
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19829
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84671/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by ash211 <gi...@git.apache.org>.
Github user ash211 commented on the issue:
https://github.com/apache/spark/pull/19829
Looks like a fix for https://issues.apache.org/jira/browse/SPARK-19552 -- should that be reopened now that netty is deprecating 4.0.x so we can't do it "Later" anymore?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19829
**[Test build #84231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84231/testReport)** for PR 19829 at commit [`93632a0`](https://github.com/apache/spark/commit/93632a071b5eef1f4d2882f547c43ed0750b1450).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19829: [WIP]Upgrade Netty to 4.1.17
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing closed the pull request at:
https://github.com/apache/spark/pull/19829
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19829
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19829
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19829
**[Test build #84670 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84670/testReport)** for PR 19829 at commit [`c7cffe9`](https://github.com/apache/spark/commit/c7cffe9f284762432d1d320845c60f8586f434af).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/19829
@ash211 Good call. I will reopen it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19829
**[Test build #84226 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84226/testReport)** for PR 19829 at commit [`14dbc71`](https://github.com/apache/spark/commit/14dbc71ac9be7d027b8d2d008f3a1350e5012dd1).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19829
**[Test build #84669 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84669/testReport)** for PR 19829 at commit [`9a07d2b`](https://github.com/apache/spark/commit/9a07d2b64c506a6d822dea27ca76255c084569f4).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19829
**[Test build #84668 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84668/testReport)** for PR 19829 at commit [`94df9ae`](https://github.com/apache/spark/commit/94df9ae0bf5216f70c17b8aed297cda22f9566f4).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class MessageWithHeader extends AbstractFileRegion `
* ` static class EncryptedMessage extends AbstractFileRegion `
* `public abstract class AbstractFileRegion extends AbstractReferenceCounted implements FileRegion `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19829
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84670/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19829
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84669/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19829: [WIP]Upgrade Netty to 4.1.17
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19829
**[Test build #84670 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84670/testReport)** for PR 19829 at commit [`c7cffe9`](https://github.com/apache/spark/commit/c7cffe9f284762432d1d320845c60f8586f434af).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class MessageWithHeader extends AbstractFileRegion `
* ` static class EncryptedMessage extends AbstractFileRegion `
* `public abstract class AbstractFileRegion extends AbstractReferenceCounted implements FileRegion `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org