[GitHub] [netbeans] junichi11 commented on a change in pull request #1963: [NETBEANS-1603] I can't see MySQL stored procedures in NetBeans

[GitBox <gi...@apache.org>]

junichi11 commented on a change in pull request #1963: [NETBEANS-1603] I can't see MySQL stored procedures in NetBeans
URL: https://github.com/apache/netbeans/pull/1963#discussion_r383006109
 
 

 ##########
 File path: ide/db/src/org/netbeans/modules/db/explorer/node/ProcedureNode.java
 ##########
 @@ -657,29 +672,26 @@ public boolean isEditSourceSupported() {
         @Override
         public String getDDL() {
             StringBuilder expression = new StringBuilder();
-            // set delimiter
             expression.append("DELIMITER ").append(DELIMITER).append(NEW_LINE); // NOI18N
-            // DDL
-            expression.append("CREATE OR REPLACE ").append(getSource());
+            expression.append("CREATE OR REPLACE ").append(getSource()); // NOI18N
             expression.append(SPACE).append(DELIMITER).append(NEW_LINE); // NOI18N
-            // unset delimiter
             expression.append("DELIMITER ; ").append(NEW_LINE); // NOI18N
             return expression.toString();
         }
 
         private String fqn(String source, String owner) {
             String upperSource = source.toUpperCase();
-            String toFind = getTypeName(getType()) + " "; // NOI18N
+            String toFind = getTypeName(getType()) + " ";
 
 Review comment:
   No. Strings might be recognized by tools even if it is blank. Please don't remove it. Basically, please leave it as it is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists